dmae: Implement 16bit endian swap for DMAECopyMem #1564
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Exzap
reviewed
May 12, 2025
src/Cafe/OS/libs/dmae/dmae.cpp
Outdated
| // swap per uint16 | ||
| uint16* srcBuffer = (uint16*)memory_getPointerFromVirtualOffset(hCPU->gpr[4]); | ||
| uint16* dstBuffer = (uint16*)memory_getPointerFromVirtualOffset(hCPU->gpr[3]); | ||
| for(uint32 i=0; i<hCPU->gpr[5]; i++) |
There was a problem hiding this comment.
I am unsure but it might be size * 2 here because it counts in multiple of 4 bytes. Do you know what behavior the homebrew expects?
There was a problem hiding this comment.
You are definitely right, I didn't take into account the size * 2 in the homebrew code and it ended up working anyway...
|
thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simply adapted from the 32bit behavior above.
Needed it for an homebrew app.