Skip to content

Fixed typo regarding indirect addressing #205

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fixed typo regarding indirect addressing #205

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Fixed typo regarding indirect addressing 
The comment previously stated that attempt 2 was "printing the memory address...", but it is meant to say "printing the data at the memory address..." since it was indirectly addressed using [the_secret]
  • Loading branch information
@saidkharboutli
saidkharboutli authored May 9, 2021
commit cfd6859308d3da4909b6a313726cc568070cd5db
2 changes: 1 addition & 1 deletion 03-bootsector-memory/boot_sect_memory.asm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ mov al, the_secret
int 0x10

; attempt 2
; It tries to print the memory address of 'the_secret' which is the correct approach.
; It tries to print the data at the memory address of 'the_secret' which is the correct approach.
; However, BIOS places our bootsector binary at address 0x7c00
; so we need to add that padding beforehand. We'll do that in attempt 3
mov al, "2"
Expand Down