Classic wizardry components #9
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chancancode
force-pushed
the
classic-wizardry-templates
branch
from
adf2b43 to
3d3c540
Compare
chancancode
force-pushed
the
classic-wizardry-components
branch
from
f82e7e0 to
3fef4f6
Compare
chancancode
force-pushed
the
classic-wizardry-templates
branch
from
3d3c540 to
f8a1eb9
Compare
chancancode
force-pushed
the
classic-wizardry-components
branch
2 times, most recently
from
893a2a9 to
e7026b4
Compare
This code has gone through a lot of refactors and repurposing, and
things have become more complicated and confusing than they needed
to be.
At present, the Wizard goes through a few "required" steps for the
basics, then shows a "ready" screen directing the user to "jump in"
but have an option to continue on for optional screens, eventually
ending on the "corporate" screen which is the final step.
On desktop, there are two groups of buttons –
1. on the left side, it shows a back button except for the first
screen
2. on the right side, there is a always a primary button (either
"next" or "jump in"), and then to its left, there is sometimes
a secondary action styled as a link (either "configure more" or
"exit setup")
On mobile, these buttons are stacked, with the back button sitting
at the bottom, if present.
In table form:
Step Back Button? Primary Action Secondary Action
------------------------------------------------------------------
First No Next N/A
------------------------------------------------------------------
... Yes Next N/A
------------------------------------------------------------------
Ready Yes Jump In Configure More
------------------------------------------------------------------
... Yes Next Exit Setup
------------------------------------------------------------------
Last Yes Jump In N/A
------------------------------------------------------------------
Back Button: without saving, go back to the last page
Next Button: save, and if successful, go to the next page
Configure More: re-skinned next button
Exit Setup: without saving, go to the home page ("finish")
Jump In: on the "ready" page, it exits the setup ("finish"), on the
last page, it saves, and if successful, go to the home page
This commit re-aligns the code to reflect this reality without the
unnecessary indirections leftover from previous refactors.
chancancode
force-pushed
the
classic-wizardry-components
branch
from
e7026b4 to
3a9dab6
Compare
Move field components into subfolders, remove dependency on string resolution with the runtime resolver.
chancancode
force-pushed
the
classic-wizardry-components
branch
from
3a9dab6 to
b5ec3b1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.