-
-
Notifications
You must be signed in to change notification settings - Fork 99
Stuck on Updating... after changing profile picture. #6656
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
it seems like it will sometimes say connected again after a long while of waiting. It also could have been me sending a message to someone from the working device that jump started it. Either way its still a weird and annoying issue. |
I could reproduce this:
This happens with Adroid 1.54.3 and Desktop 1.54.2 (even on master with newest core 1.157.1) After 1-2 minutes the connection works again, even without any other activity |
This is a complete log after changing the profile image and sending a message to SELF chat from the other device:
account changed ( 60 seconds without log entries)
connected to IMAP but message is not received ( another 60 seconds without log entries)
now the message is fetched |
Also tested with core 1.157.1 (on Desktop master) |
How long does this state last? I can reproduce it but after 1-2 minutes the connection is up again. |
It would appear the duration can vary? Although I havent tested it enough to be sure! |
I dont know if its a deltachat app issue or a chatmail server bug |
Could #6477 be related? |
I dont know. Sounds like it could be though! |
Uploading avatar via IMAP append also fails in #6658 The log line is similar to DC desktop Forcefully disabling IMAP compress here "fixes" the issue: Line 387 in 82f6103
This probably explains why the issue does not appear for @Hocuri with gmx.net at #6658, if gmx.net does not support IMAP COMPRESS. This looks like some buffering issue, compressed stream is likely not flushed properly and uploading the sync message via IMAP APPEND times out eventually. |
There was a recent fix Nullus157/async-compression#327 in async-compression 0.4.19. We are currently using async-compression 0.4.18. |
Wow good job finding the issue! |
Updating async-compression to 0.4.20 did not fix the issue, so more debugging is needed. I also tested that downgrade to 0.4.16 does not help. It still times out even though we do the flushing on our side in async-imap right after sending Still get this:
Then in async-imap we write the 12019-byte long message and flush the stream: But then this Normally protocol looks like this:
On the testing email server nothing got appended into INBOX, all maildirs are empty, so flushing likely did not work out. It is not the issue with reading the response, I don't think there is any response sent as nothing was uploaded. |
Wonder if #6611 is related, we previously sent smaller avatars around. |
I tried truncating uploaded over IMAP APPEND message and it gets flaky around 11085 bytes:
Probably also depends on the exact image uploaded and how well it compresses. I used the test in #6658 |
This is also not a Rustls bug. I tested with |
The test passes if I change this line to So it is likely a bug in async-compression. When IMAP COMPRESS was introduced I had to fix the receiver part, porting a bugfix from |
Even with buffer reduced to 256, this |
I made a fix at Nullus157/async-compression#333 |
PR updating async-compression: #6666 |
…d device (#6657) Found and fixed a bug while investigating #6656. It's not the same bug, though. Steps to reproduce this bug: - Create a new profile - Transfer it to a second device - Send a message from the first device - -> It will never arrive on the second device, instead a warning will be printed that you are using DC on multiple devices. The bug was that the key wasn't created before the backup transfer, so that the second device then created its own key instead of using the same key as the first device. In order to regression-test, this PR now changes `clone()` to use "Add second device" instead of exporting and importing a backup. Exporting and importing a backup has enough tests already. This PR also adds an unrelated test `test_selfavatar_sync()`. The bug was introduced by #6574 in v1.156.0
I'm just using the latest version for flatpak on ubuntu. But this also happened on windows version as well before.
If I'm using my phone and computer on the same profile, and I change my profile picture on one device they become out of sync and one device says updating... forever. and closing and opening the app doesn't fix it.
It also cannot receive messages.
The text was updated successfully, but these errors were encountered: