-
-
Notifications
You must be signed in to change notification settings - Fork 99
fix: Fix setting up a profile and immediately transferring to a second device #6657
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Maybe add a Rust test instead which checks that the key is the same on devices after a backup export/import? We don't even need to check that synchronization works (if keys are different, it's a bug anyway) |
I don't think it's possible to do iroh-add-second-device in Rust? And the issue only happened with iroh-add-second-device, not with export-backup |
It is possible to do everything in Rust, but better not add online tests there. We have around 5 online tests in Rust and I don't like that they fail when offline, better keep them in Python if it requires being online. |
They were only needed for debugging
Ensure the secret key exists before setting up second device
7d8aebd
to
7c55f9a
Compare
In order to regression-test, this PR now changes This PR also adds an unrelated test |
Found and fixed a bug while investigating #6656. It's not the same bug, though.
Steps to reproduce this bug:
The bug was that the key wasn't created before the backup transfer, so that the second device then created its own key instead of using the same key as the first device.
In order to regression-test, this PR now changes
clone()
to use "Add second device" instead of exporting and importing a backup. Exporting and importing a backup has enough tests already.This PR also adds an unrelated test
test_selfavatar_sync()
.The bug was introduced by #6574 in v1.156.0