fix: encrypt broadcast lists #6781
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
it was all the time questionable if not encrypting broadcast lists rules the issue that recipients may know each other cryptographically. however, meanwhile with chatmail, unncrypted broadcasts are no longer possible, and we actively broke workflows eg. from this teacher: https://support.delta.chat/t/broadcast-funktioniert-nach-update-nicht-meht/3694 this basically reverts commit 7e5907d which was that time added last-minute and without lots discussions :) let the students get their homework again :)
link2xt
approved these changes
Apr 7, 2025
|
We currently don't anonymize recipients, but I opened an issue at #6782 |
|
is the CI error related to this PR? |
No, macOS tests just time out sometimes. |
r10s
added a commit
to deltachat/deltachat-desktop
that referenced
this pull request
Apr 7, 2025
broadcasts are now encrypted as other chats, in case of chatmail, always. this change was needed as usage was broken otherwise, see chatmail/core#6781 for more details
Simon-Laux
pushed a commit
to deltachat/deltachat-desktop
that referenced
this pull request
Apr 8, 2025
broadcasts are now encrypted as other chats, in case of chatmail, always. this change was needed as usage was broken otherwise, see chatmail/core#6781 for more details
|
This also does not do anything about gossiping so Autocrypt-Gossip may be sent disclosing recipient email addresses. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
it was all the time questionable if not encrypting broadcast lists rules the issue that recipients may know each other cryptographically.
however, meanwhile with chatmail, unncrypted broadcasts are no longer possible, and we actively broke workflows eg. from this teacher: https://support.delta.chat/t/broadcast-funktioniert-nach-update-nicht-meht/3694
there will probably a much nicer "channel" update come this year, however, until then, we can support broadcasts again in its existing form. nb, they're still experimental
this basically reverts commit
7e5907d which was that time added last-minute and without lots discussions :)
let the students get their homework again :)