Skip to content

Port test_delete_deltachat_folder to JSON-RPC and restart I/O on mvbox_move change #6790

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 9, 2025
Merged

Port test_delete_deltachat_folder to JSON-RPC and restart I/O on mvbox_move change #6790

merged 2 commits into from
Apr 9, 2025

Conversation

link2xt
Copy link
Collaborator

@link2xt link2xt commented Apr 8, 2025 •
edited
Loading

Based on #6789

@link2xt
Copy link
Collaborator Author

link2xt commented Apr 8, 2025 •
edited
Loading

The test currently fails. Existing tests only passed because legacy python tests reuse accounts and the test seems to delete existing DeltaChat folder that is not used.

@link2xt
Copy link
Collaborator Author

link2xt commented Apr 8, 2025

We can look for [TRYCREATE] response when trying to MOVE, but there is also a DeltaChat loop that should eventually create the folder.

I tried connecting to the Dovecot server, selecting DeltaChat folder and deleting it while IDLE. Deleting the folder interrupts IDLE:

? OK [READ-WRITE] Select completed (0.021 + 0.000 + 0.020 secs).
? IDLE
+ idling
* BYE IMAP session state is inconsistent, please relogin.
closed

@link2xt
fix: restart I/O when mvbox_move setting is changed
634cbd1 
When the setting is enabled,
new IMAP loop should be started.
@link2xt link2xt force-pushed the link2xt/port-test_delete_deltachat_folder branch from 9ef23fd to 0213cc3 Compare April 9, 2025 00:09
@link2xt link2xt changed the title test: port test_delete_deltachat_folder to JSON-RPC Port test_delete_deltachat_folder to JSON-RPC and restart I/O on mvbox_move change Apr 9, 2025
@link2xt link2xt marked this pull request as ready for review April 9, 2025 00:09
@link2xt link2xt mentioned this pull request Apr 9, 2025
Closed
@link2xt link2xt force-pushed the link2xt/port-test_delete_deltachat_folder branch from 0213cc3 to cba2cdd Compare April 9, 2025 00:24
Base automatically changed from link2xt/add-transport-rpc-client to main April 9, 2025 12:27
@link2xt link2xt requested review from iequidoo and Hocuri and removed request for iequidoo April 9, 2025 12:28
Hocuri
Hocuri approved these changes Apr 9, 2025
View reviewed changes
@link2xt link2xt force-pushed the link2xt/port-test_delete_deltachat_folder branch from cba2cdd to 3e8987b Compare April 9, 2025 13:28
@link2xt link2xt merged commit 3e8987b into main Apr 9, 2025
29 checks passed
@link2xt link2xt deleted the link2xt/port-test_delete_deltachat_folder branch April 9, 2025 13:43
@iequidoo iequidoo mentioned this pull request Apr 10, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Hocuri Hocuri Hocuri approved these changes

@iequidoo iequidoo Awaiting requested review from iequidoo

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@link2xt @Hocuri