Feature/con 650 #389
Open
Feature/con 650 #389
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hat's a different branch...
jtnelson
requested changes
Jul 28, 2019
| return new Point(x, y); | ||
| } | ||
|
|
||
| public float getY() { |
| return y; | ||
| } | ||
|
|
||
| public float getX() { |
| @Immutable | ||
| public final class Point { | ||
|
|
||
| /** |
There was a problem hiding this comment.
There needs to be more javadoc in this class. Please see other classes in the codebase for conventions on how methods, etc javadoced
| /** | ||
| * Valid latitude values are between -90 and 90, both inclusive. | ||
| */ | ||
| public static float MIN_Y = Float.valueOf("-90.0000"); |
There was a problem hiding this comment.
why are there min and max values if a Point is generic as opposed to being lat/long?
interface/shared.thrift
Outdated
| @@ -48,7 +48,8 @@ enum Operator { | |||
| BETWEEN = 9, | |||
| LINKS_TO = 10, | |||
| LIKE = 11, | |||
| NOT_LIKE = 12 | |||
| NOT_LIKE = 12, | |||
| WITHIN = 13 | |||
There was a problem hiding this comment.
remove this, since this PR is not tackling operators for Points
| public static float MIN_X = Float.valueOf("-180.0000"); | ||
| public static float MAX_X = Float.valueOf("180.0000"); | ||
|
|
||
| private float x; |
There was a problem hiding this comment.
these should be doubles instead of floats
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@jtnelson Let me know if there's anything missing. In the video kwam sent you I expressed concern that it felt very quick?