add confirmation dialog for destructive actions #4743 #4754
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 tasks
sknep
force-pushed
the
confirm-file-storage-dialog-4743
branch
from
3960f92 to
6157c9c
Compare
sknep
force-pushed
the
confirm-file-storage-dialog-4743
branch
from
6157c9c to
dc5f425
Compare
sknep
commented
Mar 18, 2025
sknep
commented
Mar 18, 2025
sknep
force-pushed
the
confirm-file-storage-dialog-4743
branch
2 times, most recently
from
67357c3 to
e68add7
Compare
🤖 This is an automated code coverage reportTotal coverage (lines): 28.29% |
apburnes
reviewed
Mar 18, 2025
There was a problem hiding this comment.
It looks like a good start. The addition of the useCallbacks unrelated to the dialog in the site storage page hurt readability in the review and led to some confusion on what's being added. I've got questions to clarify the some of the props and keydown actions in the dialog component.
apburnes
reviewed
Mar 18, 2025
apburnes
previously approved these changes
Mar 19, 2025
sknep
force-pushed
the
confirm-file-storage-dialog-4743
branch
from
e68add7 to
2f6737d
Compare
sknep
force-pushed
the
confirm-file-storage-dialog-4743
branch
2 times, most recently
from
7c0eb5f to
db096c5
Compare
sknep
force-pushed
the
confirm-file-storage-dialog-4743
branch
from
db096c5 to
8c52cf1
Compare
apburnes
approved these changes
Mar 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this pull request:
security considerations