Skip to content

chore: Update file url to use baseUrl and file key #4755

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 19, 2025
Merged

chore: Update file url to use baseUrl and file key #4755

merged 1 commit into from
Mar 19, 2025

Conversation

apburnes
Copy link
Contributor

@apburnes apburnes commented Mar 19, 2025 •
edited
Loading

Changes proposed in this pull request:

  • Updates the file's public url to use the sites base url and file's key value
  • Removes unnecessary MemoryRouter from FileList tests
  • Fixes test cases in FileList and FileUpload that where running outside the test call stack

Notes

security considerations

None

@cloud-gov-pages-operations
Copy link
Contributor

cloud-gov-pages-operations commented Mar 19, 2025 •
edited
Loading

🤖 This is an automated code coverage report

Total coverage (lines): 28.29%
Coverage diff: 0% 📈

@apburnes apburnes requested a review from a team March 19, 2025 17:24
@apburnes apburnes force-pushed the chore-update-file-public-url branch from bcbf6f0 to 082a305 Compare March 19, 2025 20:39
@apburnes apburnes merged commit 8bd48f7 into main Mar 19, 2025
7 of 8 checks passed
@apburnes apburnes deleted the chore-update-file-public-url branch March 19, 2025 20:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drewbo drewbo drewbo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@apburnes @cloud-gov-pages-operations @drewbo