-
Notifications
You must be signed in to change notification settings - Fork 76
feat: Create a file upload hook to queue uploads #4759
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🤖 This is an automated code coverage reportTotal coverage (lines): 28.26% |
sknep
reviewed
Mar 24, 2025
sknep
reviewed
Mar 24, 2025
sknep
reviewed
Mar 24, 2025
3dbb1b1
to
af9596b
Compare
Signed-off-by: Andrew Burnes <[email protected]>
af9596b
to
a458a3b
Compare
sknep
approved these changes
Mar 26, 2025
sknep
reviewed
Mar 26, 2025
const MEGABYTE_LIMIT = 250; | ||
const MAX_FILE_SIZE = MEGABYTE_LIMIT * 1024 * 1024; // 250MB | ||
const getFileStatusColor = (status) => { | ||
if (status === 'error') return 'bg-secondary-lighter'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
would you consider a switch statement for this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Our linting prefers if
over switch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #4746
Closes #4753
Changes proposed in this pull request:
useMultiFileUpload
hook to manage a file upload queueuseFileStorage
to provide auploadFile
functionputObject
so the proxy reads the proper file type headerssecurity considerations
None