Skip to content

fix: file storage icons and mobile table styles polish #4784

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 16, 2025

Conversation

sknep
Copy link
Contributor

@sknep sknep commented Apr 15, 2025

Changes proposed in this pull request:

  • Updates icons to those from mocks for add folder/attachment buttons
  • makes button styles consistent with rest of file upload table
  • Adds mobile styles for file upload table, similar to USWDS stacking table (https://designsystem.digital.gov/components/table/#responsive-stacked-table-2)
  • use isPending rather than isLoading as well as a loading indicator, so that the table doesn't flash an "is empty" message while querying.
  • show file storage pagination only when the query returns results, rather than when empty or while querying.

security considerations

  • None, front-end only

New icons:
Screenshot 2025-04-15 at 4 32 19 PM

New mobile styles:
Screenshot 2025-04-15 at 4 32 31 PM

@sknep sknep linked an issue Apr 15, 2025 that may be closed by this pull request
5 tasks
@sknep sknep self-assigned this Apr 15, 2025
@cloud-gov-pages-operations
Copy link
Contributor

🤖 This is an automated code coverage report

Total coverage (lines): 34.08%
Coverage diff: 0% 📈

@sknep sknep requested a review from a team April 15, 2025 21:31
@sknep sknep marked this pull request as ready for review April 15, 2025 21:31
Copy link
Contributor

@apburnes apburnes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧼 💻

@sknep sknep merged commit 79842e3 into main Apr 16, 2025
9 checks passed
@sknep sknep deleted the 4780-file-storage-polish branch April 16, 2025 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Final touches for File Storage initial release
3 participants