Dev #72

Khauneesh-AI · 2025-05-30T11:03:52Z

Evaluate button in top section is disabled always (now it is fixed)
Re-evaluate does not work properly
The AiAssitant icon has been added for the Generate Custom Prompt button and the position is moved to the top right
MaxToken has been removed from Parameters section.
-Examples & Prompt for Dataset Generator Wizard is swapped
-For the Seed Instructions users can enter multi line seeds and new line will not be removed
-For the Success view of the Dataset Generation the Topics tabbed/table view will have the popover to display the whole seed instruction
-For the custom prompt generation if the examples file has been uploaded will be used to generate the custom prompt
-Minor improvements for the Generate Custom Prompt Modal

Add Free Form Workflow Type Add Free From Prompt Add use case for free form workflow type Usecase fix for freeform Show Seed Instructions for FreeForm Ftech File Content Add AG Grid Add Modules Add Themes Adding FreeFormTable Fix Examples Table for Freeform Dataset Fix Dataset Details Page for Freeforms Add Dataset Viewer Hide Exmaples Buttons for Freeforms Fix for Examples in Dataset Details Page (freeform) Update Examples Message Fix for very long seeds Fix for Dataset Details Page Fix for Freeform Table in Results Page Adding Re-generate Dataset Changes Add Evaluation for Freeforms Fix for custom prompt modal Fix Lint Errors

pagination for list view for generation , evaluation and export

Fix for SFT Examples Validation

Fix for Examples Validation

This PR contains changes for following items: Examples & Prompt for Dataset Generator Wizard is swapped For the Seed Instructions users can enter multi line seeds and new line will not be removed For the Success view of the Dataset Generation the Topics tabbed/table view will have the popover to display the whole seed instruction For the custom prompt generation if the examples file has been uploaded will be used to generate the prompt Minor improvements for the Generate Custom Prompt Modal

UI Issues that have been resolved by the PR: Evaluate button in top section is disabled always (now it is fixed) Re-evaluate does not work properly The AiAssitant icon has been added for the Generate Custom Prompt button and the position is moved to the top right MaxToken has been removed from Parameters section

Copilot

Pull Request Overview

This PR enhances the Data Generator workflows by fixing disabled buttons, improving re-evaluate behavior, swapping sections in the Dataset Generator Wizard, adding multi-line seed support, showing full seed popovers, and refining the Generate Custom Prompt modal with an AI Assistant icon.

Clean up and reorganize imports and state in file selectors and tables
Add free-form example file import/display in the Examples step
Revise CustomPromptButton modal props and include example_path in prompt generation

Reviewed Changes

Copilot reviewed 76 out of 76 changed files in this pull request and generated 8 comments.

Show a summary per file

File	Description
app/client/src/pages/DataGenerator/FilesTable.tsx	Removed unused `url` destructuring, added loading indicator, cleaned up imports and state
app/client/src/pages/DataGenerator/FileSelectorButton.tsx	Introduced optional `label` prop to button, changed to non–self-closing `<Button>`
app/client/src/pages/DataGenerator/Examples.tsx	Implemented free-form example import with file fetch, dynamic table/empty states
app/client/src/pages/DataGenerator/DataGenerator.tsx	Reordered steps, cleaned console logs, added conditional dataset hook
app/client/src/pages/DataGenerator/CustomPromptButton.tsx	Restyled modal footer, swapped `onCancel`→`onClose`, added AI icon
app/client/src/pages/DataGenerator/Configure.tsx	Added “Freeform Data Generation” option, improved form validation
app/client/src/api/api.ts	Extended default prompt hook for freeform endpoint and updated pagination support
...	...

Comments suppressed due to low confidence (1)

app/client/src/api/api.ts:30

The type WorkerType likely should be WorkflowType or another imported type; ensure the correct type is used or imported.

export const useFetchDefaultPrompt = (useCase: string, workflowType?: WorkerType): UseFetchApiReturn<FetchDefaultPromptResp> => {

Copilot · 2025-05-30T11:07:27Z

app/client/src/pages/DataGenerator/FilesTable.tsx

@@ -1,6 +1,8 @@
 import endsWith from 'lodash/endsWith';
 import filter from 'lodash/filter';
 import clone from 'lodash/clone';
+import set from 'lodash/set';


The set import is not used in this file. Consider removing it to clean up unused dependencies.

Suggested change

import set from 'lodash/set';

Copilot · 2025-05-30T11:07:28Z

app/client/src/pages/DataGenerator/FilesTable.tsx

@@ -1,6 +1,8 @@
 import endsWith from 'lodash/endsWith';
 import filter from 'lodash/filter';
 import clone from 'lodash/clone';
+import set from 'lodash/set';
+import forEach from 'lodash/forEach';


The forEach import is not used in this file. You can remove it to reduce clutter.

Suggested change

import forEach from 'lodash/forEach';

Copilot · 2025-05-30T11:07:28Z

app/client/src/pages/DataGenerator/FilesTable.tsx

@@ -81,12 +83,12 @@ const FilesTable: React.FC<Props> = ({ onSelectedRows, workflowType }) => {
  const [paths, setPaths] = useState<string[] | null>(null);
  const [path, setPath] = useState<string | null>(null);
  const [selectedRowKeys, setSelectedRowKeys] = useState<React.Key[]>([]);
-  const [selectedRows, setSelectedRows] = useState<File[]>([]);
+  const [, setSelectedRows] = useState<File[]>([]);


Both selectedRows and its setter are unused here; consider removing this state hook entirely.

Suggested change

const [, setSelectedRows] = useState<File[]>([]);

// Removed unused selectedRows state and its setter

Copilot · 2025-05-30T11:07:28Z

app/client/src/pages/DataGenerator/DataGenerator.tsx

    const initialData = location?.state?.data;
+
+    const datasetDetailsReq = location?.state?.data &&  useGetDatasetDetails(location?.state?.data?.generate_file_name)


Calling a hook (useGetDatasetDetails) conditionally can break the Rules of Hooks. Invoke the hook unconditionally and branch on its result instead.

Suggested change

const datasetDetailsReq = location?.state?.data && useGetDatasetDetails(location?.state?.data?.generate_file_name)

const datasetDetailsReq = useGetDatasetDetails(location?.state?.data?.generate_file_name || null);

Copilot · 2025-05-30T11:07:29Z

app/client/src/pages/DataGenerator/CustomPromptButton.tsx

-              onCancel={() => setShowModal(false)}
-              onOk={() => onFinish()}
+              title={`Generate Custom Prompt`}
+              onClose={() => setShowModal(false)}


Ant Design's Modal uses onCancel, not onClose. Replace onClose with onCancel to ensure the cancel action works correctly.

Suggested change

onClose={() => setShowModal(false)}

onCancel={() => setShowModal(false)}

Copilot · 2025-05-30T11:07:29Z

app/client/src/pages/DataGenerator/Examples.tsx

+                      <>
+                        <Form.Item
+                            name="example_path"
+                            tooltip='Upload a JSAON file containing examples'


Fix typo in tooltip: change "JSAON" to "JSON".

Suggested change

tooltip='Upload a JSAON file containing examples'

tooltip='Upload a JSON file containing examples'

app/client/src/pages/DataGenerator/Configure.tsx

Copilot · 2025-05-30T11:07:30Z

app/client/src/pages/DataGenerator/DataGenerator.tsx

@@ -98,10 +99,14 @@ const DataGenerator = () => {
    const [isStepValid, setIsStepValid] = useState<boolean>(false);
    // Data passed from listing table to prepopulate form
    const location = useLocation();
-    console.log('DatGenerator >> location?.state?.data:', location?.state?.data);
+    console.log('location?.state?.data:', location?.state?.data);


Remove or replace this debugging console.log with proper error handling or logging before merging.

Co-authored-by: Copilot <[email protected]>

Khauneesh-AI and others added 23 commits May 5, 2025 23:41

analyzer for prompt assist

c953d08

added analyser files required for previous commit

8051687

pagination for list view for generation , evaluation and export

8eba3ec

test cases modified for pagination

1de8d30

Merge branch 'dev' into dev-optimization

de1acd8

Merge pull request #64 from cloudera/dev-optimization

8d9cbe6

pagination for list view for generation , evaluation and export

Fix for SFT Examples Validation

6f5a22b

Merge pull request #68 from cloudera/fix-examples-issue

2ab9dd8

Fix for SFT Examples Validation

Fix for Examples Validation

ba7a9ce

Merge pull request #69 from cloudera/fix-examples-validation

d4d7df3

Fix for Examples Validation

build client with extended time limit for uv

0eec14e

solving builc client bug

f7d1dc5

project data null values as default for CDP

c7e5363

changed status for CDP null token

3ac304f

model endpoints supported and health check for CAII

dbdf41c

Changes for adding seed instructions

1e40359

New Templates

9455baa

Fix for Re-evaluate Action

40518b3

increasing timeout for aws request

02d616b

Khauneesh-AI requested a review from Copilot May 30, 2025 11:03

Copilot AI reviewed May 30, 2025

View reviewed changes

Khauneesh-AI and others added 2 commits May 30, 2025 16:54

Merge branch 'main' into dev

a2b9184

Update app/client/src/pages/DataGenerator/Configure.tsx

ad60a7a

Co-authored-by: Copilot <[email protected]>

Khauneesh-AI merged commit 54f0350 into main May 30, 2025
4 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Dev #72

Dev #72

Uh oh!

Khauneesh-AI commented May 30, 2025

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI May 30, 2025

Uh oh!

Copilot AI May 30, 2025

Uh oh!

Copilot AI May 30, 2025

Uh oh!

Copilot AI May 30, 2025

Uh oh!

Copilot AI May 30, 2025

Uh oh!

Copilot AI May 30, 2025

Uh oh!

Uh oh!

Copilot AI May 30, 2025

Uh oh!

Uh oh!

Uh oh!

	const [, setSelectedRows] = useState<File[]>([]);
	// Removed unused selectedRows state and its setter

		const initialData = location?.state?.data;

		const datasetDetailsReq = location?.state?.data && useGetDatasetDetails(location?.state?.data?.generate_file_name)

	const datasetDetailsReq = location?.state?.data && useGetDatasetDetails(location?.state?.data?.generate_file_name)
	const datasetDetailsReq = useGetDatasetDetails(location?.state?.data?.generate_file_name \|\| null);

	onClose={() => setShowModal(false)}
	onCancel={() => setShowModal(false)}

	tooltip='Upload a JSAON file containing examples'
	tooltip='Upload a JSON file containing examples'

Dev #72

Dev #72

Uh oh!

Conversation

Khauneesh-AI commented May 30, 2025

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Copilot AI May 30, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI May 30, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI May 30, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI May 30, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI May 30, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI May 30, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Copilot AI May 30, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!