Skip to content

[ui-sb] show the success icon for 2 sec when copying path #4134

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 6, 2025

Conversation

ramprasadagarwal
Copy link
Collaborator

What changes were proposed in this pull request?

  • When a user clicks on copy path, the success tick indicates that the path has been copied successfully.

How was this patch tested?

  • Added unit test

Please review Hue Contributing Guide before opening a pull request.

Screen.Recording.2025-05-05.at.3.14.20.PM.mov

@ramprasadagarwal ramprasadagarwal self-assigned this May 5, 2025
@ramprasadagarwal ramprasadagarwal requested review from bjornalm, nidhibhatg and tabraiz12 and removed request for bjornalm May 5, 2025 09:45
Copy link

github-actions bot commented May 5, 2025

✅ Test files were modified. Ensure that the tests cover all relevant changes. ✅

Copy link
Collaborator

@bjornalm bjornalm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice detail!

Copy link

github-actions bot commented May 5, 2025

Python Code Coverage

Python Coverage Report •
FileStmtsMissCoverMissing
TOTAL537112701049% 
report-only-changed-files is enabled. No files were changed during this commit :)

Pytest Report

Tests Skipped Failures Errors Time
1090 106 💤 0 ❌ 0 🔥 5m 55s ⏱️

@ramprasadagarwal ramprasadagarwal enabled auto-merge (squash) May 5, 2025 12:15
@ramprasadagarwal ramprasadagarwal merged commit 2265125 into master May 6, 2025
7 of 8 checks passed
@ramprasadagarwal ramprasadagarwal deleted the feat/storage-browser-42 branch May 6, 2025 07:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants