[ui-importer] Public API integration #4137
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Improves file handling with dedicated metadata detection API: - Adds API error handler decorator for consistent error responses - Introduces libmagic for more reliable file type detection - Separates upload and metadata detection functionality - Adds support for TSV files and multiple sheet Excel detection - Enhances metadata output with column types and sample data Removes commented-out legacy format detection code
Adds new endpoint for file metadata detection functionality Introduces python-magic library for file type detection Adds polars with calamine support for enhanced data handling Updates URL pattern for file upload endpoint to be more precise with trailing slash handling
Extracts file processing logic into a separate operation module Adds TSV to supported file formats Updates API documentation with clearer descriptions The change simplifies the upload endpoint by moving file handling logic to a dedicated operation, making the code more maintainable and easier to test.
Changes the file metadata detection endpoint to be more efficient and accurate: - Renames endpoint from 'detect_metadata' to 'guess_metadata' - Switches to GET method and improves parameter handling - Optimizes file reading by using sampling instead of full file loads - Simplifies metadata response to include only essential information - Adds support for both local and remote file systems - Improves memory usage by using file streams and BytesIO The changes make the API more RESTful and improve performance for large files by using content sampling.
Changes request data source from body to query params for file metadata Adds proper UTF-8 decoding for file samples Enhances error logging with full stack traces Improves robustness of CSV/delimited file handling by properly handling byte streams Removes unnecessary file existence check that could cause false negatives
Enhances file type detection reliability by: - Adding proper error handling for python-magic import - Removing dependency on file extensions for type detection - Simplifying delimiter-based file format detection logic - Improving error messaging when magic lib is unavailable Makes file type detection more robust and maintainable by focusing on content analysis rather than extensions.
Implements new preview endpoint to support file imports with: - Excel file preview with sheet selection - Delimited file preview (CSV, TSV) with configurable separators - SQL type mapping for multiple dialects (Hive, Impala, Trino, Phoenix, SparkSQL) - Automatic header detection - Error handling improvements for file processing Enhances the importer API with robust data preview capabilities before import
|
✅ Test files were modified. Ensure that the tests cover all relevant changes. ✅ |
Improves file handling with dedicated metadata detection API: - Adds API error handler decorator for consistent error responses - Introduces libmagic for more reliable file type detection - Separates upload and metadata detection functionality - Adds support for TSV files and multiple sheet Excel detection - Enhances metadata output with column types and sample data Removes commented-out legacy format detection code
Adds new endpoint for file metadata detection functionality Introduces python-magic library for file type detection Adds polars with calamine support for enhanced data handling Updates URL pattern for file upload endpoint to be more precise with trailing slash handling
Extracts file processing logic into a separate operation module Adds TSV to supported file formats Updates API documentation with clearer descriptions The change simplifies the upload endpoint by moving file handling logic to a dedicated operation, making the code more maintainable and easier to test.
Changes the file metadata detection endpoint to be more efficient and accurate: - Renames endpoint from 'detect_metadata' to 'guess_metadata' - Switches to GET method and improves parameter handling - Optimizes file reading by using sampling instead of full file loads - Simplifies metadata response to include only essential information - Adds support for both local and remote file systems - Improves memory usage by using file streams and BytesIO The changes make the API more RESTful and improve performance for large files by using content sampling.
Changes request data source from body to query params for file metadata Adds proper UTF-8 decoding for file samples Enhances error logging with full stack traces Improves robustness of CSV/delimited file handling by properly handling byte streams Removes unnecessary file existence check that could cause false negatives
Enhances file type detection reliability by: - Adding proper error handling for python-magic import - Removing dependency on file extensions for type detection - Simplifying delimiter-based file format detection logic - Improving error messaging when magic lib is unavailable Makes file type detection more robust and maintainable by focusing on content analysis rather than extensions.
Implements new preview endpoint to support file imports with: - Excel file preview with sheet selection - Delimited file preview (CSV, TSV) with configurable separators - SQL type mapping for multiple dialects (Hive, Impala, Trino, Phoenix, SparkSQL) - Automatic header detection - Error handling improvements for file processing Enhances the importer API with robust data preview capabilities before import
Harshg999
force-pushed
the
new-importer-working-dir
branch
from
92bb7d1 to
5ed73c2
Compare
…to feat/importer-6
Improves file handling with dedicated metadata detection API: - Adds API error handler decorator for consistent error responses - Introduces libmagic for more reliable file type detection - Separates upload and metadata detection functionality - Adds support for TSV files and multiple sheet Excel detection - Enhances metadata output with column types and sample data Removes commented-out legacy format detection code
Adds new endpoint for file metadata detection functionality Introduces python-magic library for file type detection Adds polars with calamine support for enhanced data handling Updates URL pattern for file upload endpoint to be more precise with trailing slash handling
Extracts file processing logic into a separate operation module Adds TSV to supported file formats Updates API documentation with clearer descriptions The change simplifies the upload endpoint by moving file handling logic to a dedicated operation, making the code more maintainable and easier to test.
Changes the file metadata detection endpoint to be more efficient and accurate: - Renames endpoint from 'detect_metadata' to 'guess_metadata' - Switches to GET method and improves parameter handling - Optimizes file reading by using sampling instead of full file loads - Simplifies metadata response to include only essential information - Adds support for both local and remote file systems - Improves memory usage by using file streams and BytesIO The changes make the API more RESTful and improve performance for large files by using content sampling.
Changes request data source from body to query params for file metadata Adds proper UTF-8 decoding for file samples Enhances error logging with full stack traces Improves robustness of CSV/delimited file handling by properly handling byte streams Removes unnecessary file existence check that could cause false negatives
Enhances file type detection reliability by: - Adding proper error handling for python-magic import - Removing dependency on file extensions for type detection - Simplifying delimiter-based file format detection logic - Improving error messaging when magic lib is unavailable Makes file type detection more robust and maintainable by focusing on content analysis rather than extensions.
Implements new preview endpoint to support file imports with: - Excel file preview with sheet selection - Delimited file preview (CSV, TSV) with configurable separators - SQL type mapping for multiple dialects (Hive, Impala, Trino, Phoenix, SparkSQL) - Automatic header detection - Error handling improvements for file processing Enhances the importer API with robust data preview capabilities before import
Harshg999
force-pushed
the
new-importer-working-dir
branch
from
5ed73c2 to
04bcf00
Compare
Harshg999
force-pushed
the
new-importer-working-dir
branch
from
7771b36 to
f0d3ecb
Compare
Harshg999
force-pushed
the
new-importer-working-dir
branch
from
583a86d to
708e75a
Compare
UI Coverage Report
|
Python Coverage Report •
Pytest Report
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
How was this patch tested?
Please review Hue Contributing Guide before opening a pull request.