Skip to content

Add an event-subscriptions subcommand #9064

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jul 7, 2025
Merged

Conversation

sdnts
Copy link
Contributor

@sdnts sdnts commented Apr 25, 2025

Fixes MQ-845

This PR adds a new subcommand. I've marked it as hidden for now till the local de experience is finished (I'll do that in a separate PR)


  • Tests
    • TODO (before merge)
    • Tests included
    • Tests not necessary because:
  • Wrangler / Vite E2E Tests CI Job required? (Use "e2e" label or ask maintainer to run separately)
    • I don't know
    • Required
    • Not required because:
  • Public documentation
    • TODO (before merge)
    • Cloudflare docs PR(s):
    • Documentation not necessary because: it will come when we un-hide this command
  • Wrangler V3 Backport
    • TODO (before merge)
    • Wrangler PR:
    • Not necessary because: this is a new subcommand

@sdnts sdnts requested a review from a team as a code owner April 25, 2025 18:55
Copy link

changeset-bot bot commented Apr 25, 2025

🦋 Changeset detected

Latest commit: 730dfcf

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
wrangler Minor
@cloudflare/vite-plugin Major
@cloudflare/vitest-pool-workers Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

github-actions bot commented Apr 30, 2025

A Wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/14848491790/npm-package-wrangler-9064
Prereleases for other packages:

cloudflare-workers-bindings-extension:

wget https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/14848491790/npm-package-cloudflare-workers-bindings-extension-9064 -O ./cloudflare-workers-bindings-extension.0.0.0-vc15ab176b.vsix && code --install-extension ./cloudflare-workers-bindings-extension.0.0.0-vc15ab176b.vsix

create-cloudflare:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/14848491790/npm-package-create-cloudflare-9064 --no-auto-update

@cloudflare/kv-asset-handler:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/14848491790/npm-package-cloudflare-kv-asset-handler-9064

miniflare:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/14848491790/npm-package-miniflare-9064

@cloudflare/pages-shared:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/14848491790/npm-package-cloudflare-pages-shared-9064

@cloudflare/unenv-preset:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/14848491790/npm-package-cloudflare-unenv-preset-9064

@cloudflare/vite-plugin:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/14848491790/npm-package-cloudflare-vite-plugin-9064

@cloudflare/vitest-pool-workers:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/14848491790/npm-package-cloudflare-vitest-pool-workers-9064

@cloudflare/workers-editor-shared:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/14848491790/npm-package-cloudflare-workers-editor-shared-9064

@cloudflare/workers-shared:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/14848491790/npm-package-cloudflare-workers-shared-9064

@cloudflare/workflows-shared:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/14848491790/npm-package-cloudflare-workflows-shared-9064

Note that these links will no longer work once the GitHub Actions artifact expires.

@sdnts sdnts force-pushed the main branch 2 times, most recently from 71e1e9c to b8624c5 Compare May 5, 2025 15:02
@petebacondarwin petebacondarwin added e2e Run wrangler + vite-plugin e2e tests on a PR and removed e2e Run wrangler + vite-plugin e2e tests on a PR labels Jun 2, 2025
Copy link
Contributor

@penalosa penalosa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One nit about statuses, but otherwise LGTM! Sorry about the delay here

@github-project-automation github-project-automation bot moved this from Untriaged to Approved in workers-sdk Jun 2, 2025
@petebacondarwin petebacondarwin self-assigned this Jul 4, 2025
Copy link

pkg-pr-new bot commented Jul 4, 2025

create-cloudflare

npm i https://pkg.pr.new/create-cloudflare@9064

@cloudflare/kv-asset-handler

npm i https://pkg.pr.new/@cloudflare/kv-asset-handler@9064

miniflare

npm i https://pkg.pr.new/miniflare@9064

@cloudflare/pages-shared

npm i https://pkg.pr.new/@cloudflare/pages-shared@9064

@cloudflare/unenv-preset

npm i https://pkg.pr.new/@cloudflare/unenv-preset@9064

@cloudflare/vite-plugin

npm i https://pkg.pr.new/@cloudflare/vite-plugin@9064

@cloudflare/vitest-pool-workers

npm i https://pkg.pr.new/@cloudflare/vitest-pool-workers@9064

@cloudflare/workers-editor-shared

npm i https://pkg.pr.new/@cloudflare/workers-editor-shared@9064

wrangler

npm i https://pkg.pr.new/wrangler@9064

commit: 730dfcf

@petebacondarwin petebacondarwin force-pushed the main branch 2 times, most recently from 0d8e9fc to 88c532d Compare July 6, 2025 18:49
@petebacondarwin petebacondarwin added this pull request to the merge queue Jul 7, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jul 7, 2025
@petebacondarwin petebacondarwin added this pull request to the merge queue Jul 7, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jul 7, 2025
@petebacondarwin petebacondarwin added this pull request to the merge queue Jul 7, 2025
Merged via the queue into cloudflare:main with commit a1181bf Jul 7, 2025
32 of 33 checks passed
@github-project-automation github-project-automation bot moved this from Approved to Done in workers-sdk Jul 7, 2025
@workers-devprod workers-devprod added the contribution [Holopin] Recognizes an open-source contribution, big or small label Jul 7, 2025
Copy link

holopin-bot bot commented Jul 7, 2025

Congratulations @sdnts, the maintainer of this repository has issued you a holobyte! Here it is: https://holopin.io/holobyte/cmcsxxq2l1319507jru2t1jswl

This badge can only be claimed by you, so make sure that your GitHub account is linked to your Holopin account. You can manage those preferences here: https://holopin.io/account.
Or if you're new to Holopin, you can simply sign up with GitHub, which will do the trick!

@workers-devprod workers-devprod mentioned this pull request Jul 6, 2025
emily-shen pushed a commit that referenced this pull request Jul 7, 2025
* feat: add an `event-subscriptions` subcommand

* fix: Queues `wrangler --help` emoji

* fixup! feat: add an `event-subscriptions` subcommand

* improve reliability of workers-with-assets fixture tests

* clean up worker after deployments e2e tests

* ci: add diagnostics to test-and-check action

---------

Co-authored-by: Peter Bacon Darwin <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribution [Holopin] Recognizes an open-source contribution, big or small
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants