-
Notifications
You must be signed in to change notification settings - Fork 925
add mTLS mixed mode support #9443
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🦋 Changeset detectedLatest commit: c01297e The changes in this PR will be included in the next version bump. This PR includes changesets to release 5 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
ae18378
to
b22cb6c
Compare
A Wrangler prerelease is available for testing. You can install this latest build in your project with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/15467775616/npm-package-wrangler-9443 Prereleases for other packages:
wget https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/15467775616/npm-package-cloudflare-workers-bindings-extension-9443 -O ./cloudflare-workers-bindings-extension.0.0.0-v5e982bb83.vsix && code --install-extension ./cloudflare-workers-bindings-extension.0.0.0-v5e982bb83.vsix
npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/15467775616/npm-package-create-cloudflare-9443 --no-auto-update
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/15467775616/npm-package-cloudflare-kv-asset-handler-9443
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/15467775616/npm-package-miniflare-9443
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/15467775616/npm-package-cloudflare-pages-shared-9443
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/15467775616/npm-package-cloudflare-unenv-preset-9443
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/15467775616/npm-package-cloudflare-vite-plugin-9443
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/15467775616/npm-package-cloudflare-vitest-pool-workers-9443
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/15467775616/npm-package-cloudflare-workers-editor-shared-9443
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/15467775616/npm-package-cloudflare-workers-shared-9443
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/15467775616/npm-package-cloudflare-workflows-shared-9443 Note that these links will no longer work once the GitHub Actions artifact expires. |
e419393
to
256e0ae
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Other comments (2)
- packages/wrangler/e2e/helpers/cert.ts (5-61) There appears to be significant overlap between `generateRootCertificate()` and `generateRootCaCert()` functions. Both generate self-signed root certificates with similar properties but have different implementations. Consider consolidating these into a single function with parameters to handle any specific differences.
-
packages/wrangler/src/utils/print-bindings.ts (548-552)
The nested ternary expressions for determining the `isSimulatedLocally` value are difficult to read. Consider simplifying this logic or extracting it to a helper function for better readability.
For example:
isSimulatedLocally: getFlag("MIXED_MODE") ? remote === true || remote === undefined ? false : undefined : false,
f2423ae
to
676e490
Compare
676e490
to
d16539f
Compare
create-cloudflare
@cloudflare/kv-asset-handler
miniflare
@cloudflare/pages-shared
@cloudflare/unenv-preset
@cloudflare/vite-plugin
@cloudflare/vitest-pool-workers
@cloudflare/workers-editor-shared
wrangler
commit: |
d16539f
to
c01297e
Compare
Fixes https://jira.cfdata.org/browse/DEVX-1900
This PR is adding mTLS support to mixed mode.
As part of this the PR is also adding a
workerName
option to thestartMixedModeSession
API since when startingthe remote preview with an mTLS binding we would normally get the following error:
having the option to pass the worker's name to
startMixedModeSession
allows us to make the server proxy worker behave like the actual user's worker thus enabling mTLS usage for it (in case the user has already deployed the worker)