Skip to content

chore: update node versions in various places #9451

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 11, 2025
Merged

Conversation

emily-shen
Copy link
Contributor

  • update engines, volta.node field in package.jsons
  • update c3 tests to use a slightly more recent release of node 20, since the angular cli dependabot bump needed > 20.19

  • Tests
    • TODO (before merge)
    • Tests included
    • Tests not necessary because: should just make sure existing tests don't fail
  • Wrangler / Vite E2E Tests CI Job required? (Use "e2e" label or ask maintainer to run separately)
    • I don't know
    • Required
    • Not required because: should just make sure existing tests don't fail
  • Public documentation
    • TODO (before merge)
    • Cloudflare docs PR(s):
    • Documentation not necessary because: internal chore
  • Wrangler V3 Backport
    • TODO (before merge)
    • Wrangler PR:
    • Not necessary because: v3 doesn't follow same node version policy

@emily-shen emily-shen requested a review from a team as a code owner June 3, 2025 12:57
Copy link

changeset-bot bot commented Jun 3, 2025

⚠️ No Changeset found

Latest commit: 7a66624

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

@windsurf-bot windsurf-bot bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 🤙

Copy link
Contributor

github-actions bot commented Jun 3, 2025

A Wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/15442207081/npm-package-wrangler-9451
Prereleases for other packages:

cloudflare-workers-bindings-extension:

wget https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/15442207081/npm-package-cloudflare-workers-bindings-extension-9451 -O ./cloudflare-workers-bindings-extension.0.0.0-ve114e40fd.vsix && code --install-extension ./cloudflare-workers-bindings-extension.0.0.0-ve114e40fd.vsix

create-cloudflare:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/15442207081/npm-package-create-cloudflare-9451 --no-auto-update

@cloudflare/kv-asset-handler:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/15442207081/npm-package-cloudflare-kv-asset-handler-9451

miniflare:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/15442207081/npm-package-miniflare-9451

@cloudflare/pages-shared:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/15442207081/npm-package-cloudflare-pages-shared-9451

@cloudflare/unenv-preset:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/15442207081/npm-package-cloudflare-unenv-preset-9451

@cloudflare/vite-plugin:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/15442207081/npm-package-cloudflare-vite-plugin-9451

@cloudflare/vitest-pool-workers:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/15442207081/npm-package-cloudflare-vitest-pool-workers-9451

@cloudflare/workers-editor-shared:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/15442207081/npm-package-cloudflare-workers-editor-shared-9451

@cloudflare/workers-shared:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/15442207081/npm-package-cloudflare-workers-shared-9451

@cloudflare/workflows-shared:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/15442207081/npm-package-cloudflare-workflows-shared-9451

Note that these links will no longer work once the GitHub Actions artifact expires.

@@ -39,7 +39,7 @@ jobs:
if: steps.changes.outputs.everything_but_markdown == 'true'
uses: ./.github/actions/install-dependencies
with:
node-version: 20.11.1
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we make this 20 so that it picks up the latest version all the time?

@emily-shen emily-shen requested a review from edmundhung June 4, 2025 12:25
@@ -169,7 +169,7 @@
"fsevents": "~2.3.2"
},
"engines": {
"node": ">=18.0.0"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this will make users running Wrangler on node 18 a hard failure?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we already hard fail on node 18 right? i'm not sure if i've misunderstood

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

True. I think the difference might be the error message that show up as node (or npm?) will fails it before Wrangler runs, so users might find the error less helpful, which might be fine?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was wrong. Just give it a test with node 18 and it looks good 👍🏼

npm warn EBADENGINE Unsupported engine {
npm warn EBADENGINE   package: '[email protected]',
npm warn EBADENGINE   required: { node: '>=20.0.0' },
npm warn EBADENGINE   current: { node: 'v18.20.4', npm: '10.7.0' }
npm warn EBADENGINE }
npm warn EBADENGINE Unsupported engine {
npm warn EBADENGINE   package: '@cloudflare/[email protected]',
npm warn EBADENGINE   required: { node: '>=20.0.0' },
npm warn EBADENGINE   current: { node: 'v18.20.4', npm: '10.7.0' }
npm warn EBADENGINE }
npm warn EBADENGINE Unsupported engine {
npm warn EBADENGINE   package: '[email protected]',
npm warn EBADENGINE   required: { node: '>=20.0.0' },
npm warn EBADENGINE   current: { node: 'v18.20.4', npm: '10.7.0' }
npm warn EBADENGINE }
Wrangler requires at least Node.js v20.0.0. You are using v18.20.4. Please update your version of Node.js.

Consider using a Node.js version manager such as https://volta.sh/ or https://github.com/nvm-sh/nvm.

@github-project-automation github-project-automation bot moved this from Untriaged to Approved in workers-sdk Jun 9, 2025
@emily-shen emily-shen added this pull request to the merge queue Jun 11, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jun 11, 2025
@emily-shen emily-shen added this pull request to the merge queue Jun 11, 2025
Merged via the queue into main with commit 91e5f7f Jun 11, 2025
19 checks passed
@emily-shen emily-shen deleted the emily/node-20 branch June 11, 2025 20:15
@github-project-automation github-project-automation bot moved this from Approved to Done in workers-sdk Jun 11, 2025
penalosa added a commit that referenced this pull request Jun 12, 2025
penalosa added a commit that referenced this pull request Jun 12, 2025
penalosa added a commit that referenced this pull request Jun 12, 2025
penalosa added a commit that referenced this pull request Jun 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants