-
Notifications
You must be signed in to change notification settings - Fork 925
chore: update node versions in various places #9451
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me 🤙
A Wrangler prerelease is available for testing. You can install this latest build in your project with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/15442207081/npm-package-wrangler-9451 Prereleases for other packages:
wget https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/15442207081/npm-package-cloudflare-workers-bindings-extension-9451 -O ./cloudflare-workers-bindings-extension.0.0.0-ve114e40fd.vsix && code --install-extension ./cloudflare-workers-bindings-extension.0.0.0-ve114e40fd.vsix
npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/15442207081/npm-package-create-cloudflare-9451 --no-auto-update
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/15442207081/npm-package-cloudflare-kv-asset-handler-9451
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/15442207081/npm-package-miniflare-9451
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/15442207081/npm-package-cloudflare-pages-shared-9451
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/15442207081/npm-package-cloudflare-unenv-preset-9451
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/15442207081/npm-package-cloudflare-vite-plugin-9451
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/15442207081/npm-package-cloudflare-vitest-pool-workers-9451
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/15442207081/npm-package-cloudflare-workers-editor-shared-9451
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/15442207081/npm-package-cloudflare-workers-shared-9451
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/15442207081/npm-package-cloudflare-workflows-shared-9451 Note that these links will no longer work once the GitHub Actions artifact expires. |
@@ -39,7 +39,7 @@ jobs: | |||
if: steps.changes.outputs.everything_but_markdown == 'true' | |||
uses: ./.github/actions/install-dependencies | |||
with: | |||
node-version: 20.11.1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we make this 20
so that it picks up the latest version all the time?
@@ -169,7 +169,7 @@ | |||
"fsevents": "~2.3.2" | |||
}, | |||
"engines": { | |||
"node": ">=18.0.0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this will make users running Wrangler on node 18 a hard failure?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we already hard fail on node 18 right? i'm not sure if i've misunderstood
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
True. I think the difference might be the error message that show up as node (or npm?) will fails it before Wrangler runs, so users might find the error less helpful, which might be fine?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was wrong. Just give it a test with node 18 and it looks good 👍🏼
npm warn EBADENGINE Unsupported engine {
npm warn EBADENGINE package: '[email protected]',
npm warn EBADENGINE required: { node: '>=20.0.0' },
npm warn EBADENGINE current: { node: 'v18.20.4', npm: '10.7.0' }
npm warn EBADENGINE }
npm warn EBADENGINE Unsupported engine {
npm warn EBADENGINE package: '@cloudflare/[email protected]',
npm warn EBADENGINE required: { node: '>=20.0.0' },
npm warn EBADENGINE current: { node: 'v18.20.4', npm: '10.7.0' }
npm warn EBADENGINE }
npm warn EBADENGINE Unsupported engine {
npm warn EBADENGINE package: '[email protected]',
npm warn EBADENGINE required: { node: '>=20.0.0' },
npm warn EBADENGINE current: { node: 'v18.20.4', npm: '10.7.0' }
npm warn EBADENGINE }
Wrangler requires at least Node.js v20.0.0. You are using v18.20.4. Please update your version of Node.js.
Consider using a Node.js version manager such as https://volta.sh/ or https://github.com/nvm-sh/nvm.
engines
,volta.node
field in package.jsons