Skip to content

Dispose Miniflare when Vite plugin closes #9490

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

petebacondarwin
Copy link
Contributor

  • Tests
    • TODO (before merge)
    • Tests included
    • Tests not necessary because:
  • Wrangler / Vite E2E Tests CI Job required? (Use "e2e" label or ask maintainer to run separately)
    • I don't know
    • Required
    • Not required because:
  • Public documentation
    • TODO (before merge)
    • Cloudflare docs PR(s):
    • Documentation not necessary because: minor fix
  • Wrangler V3 Backport
    • TODO (before merge)
    • Wrangler PR:
    • Not necessary because: vite plugin not backported

@petebacondarwin petebacondarwin requested review from a team as code owners June 5, 2025 09:55
Copy link

changeset-bot bot commented Jun 5, 2025

🦋 Changeset detected

Latest commit: 228ba99

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@cloudflare/vite-plugin Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@petebacondarwin petebacondarwin marked this pull request as draft June 5, 2025 09:55
@github-project-automation github-project-automation bot moved this to Untriaged in workers-sdk Jun 5, 2025
@petebacondarwin petebacondarwin added e2e Run wrangler + vite-plugin e2e tests on a PR every-os Run tests (unit/e2e/c3-e2e) on every OS, rather than just macOS labels Jun 5, 2025
Copy link
Contributor

github-actions bot commented Jun 5, 2025

A Wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/15471167740/npm-package-wrangler-9490
Prereleases for other packages:

cloudflare-workers-bindings-extension:

wget https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/15471167740/npm-package-cloudflare-workers-bindings-extension-9490 -O ./cloudflare-workers-bindings-extension.0.0.0-v2fe0d5538.vsix && code --install-extension ./cloudflare-workers-bindings-extension.0.0.0-v2fe0d5538.vsix

create-cloudflare:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/15471167740/npm-package-create-cloudflare-9490 --no-auto-update

@cloudflare/kv-asset-handler:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/15471167740/npm-package-cloudflare-kv-asset-handler-9490

miniflare:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/15471167740/npm-package-miniflare-9490

@cloudflare/pages-shared:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/15471167740/npm-package-cloudflare-pages-shared-9490

@cloudflare/unenv-preset:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/15471167740/npm-package-cloudflare-unenv-preset-9490

@cloudflare/vite-plugin:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/15471167740/npm-package-cloudflare-vite-plugin-9490

@cloudflare/vitest-pool-workers:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/15471167740/npm-package-cloudflare-vitest-pool-workers-9490

@cloudflare/workers-editor-shared:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/15471167740/npm-package-cloudflare-workers-editor-shared-9490

@cloudflare/workers-shared:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/15471167740/npm-package-cloudflare-workers-shared-9490

@cloudflare/workflows-shared:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/15471167740/npm-package-cloudflare-workflows-shared-9490

Note that these links will no longer work once the GitHub Actions artifact expires.

@petebacondarwin petebacondarwin force-pushed the pbd/miniflare/tree-kill-workerd branch 6 times, most recently from eca647d to edda199 Compare June 5, 2025 16:42
@petebacondarwin petebacondarwin marked this pull request as ready for review June 5, 2025 17:29
@petebacondarwin petebacondarwin force-pushed the pbd/miniflare/tree-kill-workerd branch from edda199 to 228ba99 Compare June 5, 2025 17:31
@petebacondarwin petebacondarwin marked this pull request as draft July 7, 2025 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
e2e Run wrangler + vite-plugin e2e tests on a PR every-os Run tests (unit/e2e/c3-e2e) on every OS, rather than just macOS
Projects
Status: Untriaged
Development

Successfully merging this pull request may close these issues.

1 participant