Skip to content

make sure that remote binding errors are surfaced when using mixed (hybrid) mode #9515

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 11, 2025

Conversation

dario-piotrowicz
Copy link
Member

@dario-piotrowicz dario-piotrowicz commented Jun 6, 2025

Fixes https://jira.cfdata.org/browse/DEVX-1954


  • Tests
    • TODO (before merge)
    • Tests included
    • Tests not necessary because:
  • Wrangler / Vite E2E Tests CI Job required? (Use "e2e" label or ask maintainer to run separately)
    • I don't know
    • Required
    • Not required because:
  • Public documentation
    • TODO (before merge)
    • Cloudflare docs PR(s):
    • Documentation not necessary because: DX fix/improvement on an undocumented feature
  • Wrangler V3 Backport
    • TODO (before merge)
    • Wrangler PR:
    • Not necessary because: not a v3 backported feature

@dario-piotrowicz dario-piotrowicz requested a review from a team as a code owner June 6, 2025 17:02
@dario-piotrowicz dario-piotrowicz added the e2e Run wrangler + vite-plugin e2e tests on a PR label Jun 6, 2025
Copy link

changeset-bot bot commented Jun 6, 2025

🦋 Changeset detected

Latest commit: f6ec879

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
wrangler Patch
@cloudflare/vitest-pool-workers Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@dario-piotrowicz dario-piotrowicz marked this pull request as draft June 6, 2025 17:02
@github-project-automation github-project-automation bot moved this to Untriaged in workers-sdk Jun 6, 2025
Copy link

pkg-pr-new bot commented Jun 6, 2025

create-cloudflare

npm i https://pkg.pr.new/create-cloudflare@9515

@cloudflare/kv-asset-handler

npm i https://pkg.pr.new/@cloudflare/kv-asset-handler@9515

miniflare

npm i https://pkg.pr.new/miniflare@9515

@cloudflare/pages-shared

npm i https://pkg.pr.new/@cloudflare/pages-shared@9515

@cloudflare/unenv-preset

npm i https://pkg.pr.new/@cloudflare/unenv-preset@9515

@cloudflare/vite-plugin

npm i https://pkg.pr.new/@cloudflare/vite-plugin@9515

@cloudflare/vitest-pool-workers

npm i https://pkg.pr.new/@cloudflare/vitest-pool-workers@9515

@cloudflare/workers-editor-shared

npm i https://pkg.pr.new/@cloudflare/workers-editor-shared@9515

wrangler

npm i https://pkg.pr.new/wrangler@9515

commit: f6ec879

@dario-piotrowicz dario-piotrowicz force-pushed the dario/slightly-improve-print-bindings branch from 1ee58f4 to 8a4486e Compare June 9, 2025 09:38
@dario-piotrowicz dario-piotrowicz marked this pull request as ready for review June 9, 2025 12:02
@dario-piotrowicz dario-piotrowicz requested a review from penalosa June 9, 2025 12:03
@github-project-automation github-project-automation bot moved this from Untriaged to Approved in workers-sdk Jun 9, 2025
@dario-piotrowicz dario-piotrowicz force-pushed the dario/slightly-improve-print-bindings branch from 8a4486e to 2297ac3 Compare June 10, 2025 09:28
@dario-piotrowicz dario-piotrowicz force-pushed the dario/DEVX-1954/change-mixed-mode-log-level branch from 5fc61ca to ad2ae6d Compare June 10, 2025 09:29
Base automatically changed from dario/slightly-improve-print-bindings to main June 11, 2025 14:15
@dario-piotrowicz dario-piotrowicz force-pushed the dario/DEVX-1954/change-mixed-mode-log-level branch from ad2ae6d to f6ec879 Compare June 11, 2025 14:48
Copy link
Contributor

Failed to automatically backport this PR's changes to Wrangler v3. Please manually create a PR targeting the v3-maintenance branch with your changes. Thank you for helping us keep Wrangler v3 supported!

Depending on your changes, running git rebase --onto v3-maintenance main dario/DEVX-1954/change-mixed-mode-log-level might be a good starting point.

@dario-piotrowicz dario-piotrowicz added the skip-v3-pr Skip validation of presence of a v3 backport PR label Jun 11, 2025
@dario-piotrowicz dario-piotrowicz added this pull request to the merge queue Jun 11, 2025
Merged via the queue into main with commit 9e4cd16 Jun 11, 2025
33 of 37 checks passed
@dario-piotrowicz dario-piotrowicz deleted the dario/DEVX-1954/change-mixed-mode-log-level branch June 11, 2025 15:04
@github-project-automation github-project-automation bot moved this from Approved to Done in workers-sdk Jun 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
e2e Run wrangler + vite-plugin e2e tests on a PR skip-v3-pr Skip validation of presence of a v3 backport PR
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants