Skip to content

refactor: run C3 e2e tests more easily locally and individually #9533

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 12 commits into from
Jul 1, 2025
Merged

refactor: run C3 e2e tests more easily locally and individually #9533

merged 12 commits into from
Jul 1, 2025

Conversation

petebacondarwin
Copy link
Contributor

  • Tests
    • TODO (before merge)
    • Tests included
    • Tests not necessary because:
  • Wrangler / Vite E2E Tests CI Job required? (Use "e2e" label or ask maintainer to run separately)
    • I don't know
    • Required
    • Not required because: c3
  • Public documentation
    • TODO (before merge)
    • Cloudflare docs PR(s):
    • Documentation not necessary because: test refactor
  • Wrangler V3 Backport
    • TODO (before merge)
    • Wrangler PR:
    • Not necessary because: c3

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Jun 9, 2025 •
edited
Loading

🦋 Changeset detected

Latest commit: 0120f91

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@cloudflare/vitest-pool-workers Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-project-automation github-project-automation bot moved this to Untriaged in workers-sdk Jun 9, 2025
@workers-devprod workers-devprod added the c3-e2e Run c3 e2e tests on a PR label Jun 9, 2025
@petebacondarwin petebacondarwin added the every-os Run tests (unit/e2e/c3-e2e) on every OS, rather than just macOS label Jun 9, 2025
@pkg-pr-new pkg.pr.new
Copy link

pkg-pr-new bot commented Jun 9, 2025 •
edited
Loading

create-cloudflare

npm i https://pkg.pr.new/create-cloudflare@9533

@cloudflare/kv-asset-handler

npm i https://pkg.pr.new/@cloudflare/kv-asset-handler@9533

miniflare

npm i https://pkg.pr.new/miniflare@9533

@cloudflare/pages-shared

npm i https://pkg.pr.new/@cloudflare/pages-shared@9533

@cloudflare/unenv-preset

npm i https://pkg.pr.new/@cloudflare/unenv-preset@9533

@cloudflare/vite-plugin

npm i https://pkg.pr.new/@cloudflare/vite-plugin@9533

@cloudflare/vitest-pool-workers

npm i https://pkg.pr.new/@cloudflare/vitest-pool-workers@9533

@cloudflare/workers-editor-shared

npm i https://pkg.pr.new/@cloudflare/workers-editor-shared@9533

wrangler

npm i https://pkg.pr.new/wrangler@9533

commit: 0120f91

@petebacondarwin petebacondarwin force-pushed the pbd/c3/run-framework-tests-individually branch 13 times, most recently from db46bd5 to 40e912b Compare June 11, 2025 12:29
@petebacondarwin petebacondarwin force-pushed the pbd/c3/run-framework-tests-individually branch from a339f66 to bfb1c7d Compare June 20, 2025 12:13
@petebacondarwin petebacondarwin force-pushed the pbd/c3/run-framework-tests-individually branch 2 times, most recently from 974386e to ff0ffe8 Compare June 30, 2025 09:13
@petebacondarwin petebacondarwin removed c3-e2e Run c3 e2e tests on a PR every-os Run tests (unit/e2e/c3-e2e) on every OS, rather than just macOS labels Jun 30, 2025
@petebacondarwin petebacondarwin force-pushed the pbd/c3/run-framework-tests-individually branch from ff0ffe8 to 5906137 Compare June 30, 2025 10:25
@workers-devprod workers-devprod added the c3-e2e Run c3 e2e tests on a PR label Jun 30, 2025
@petebacondarwin petebacondarwin force-pushed the pbd/c3/run-framework-tests-individually branch from 5906137 to 60a83c3 Compare June 30, 2025 11:35
@petebacondarwin
fix: ensure that the sourcemap-codec library has been transformed c…
518979a 
…orrectly to be imported in workerd during Vitest runs

Prior to this the inline snapshot tests were failing because they use the `magic-string` library, which in turn relies upon the `sourcemap-codec` library.

This resulted in errors that look like:

```
Error running worker: SyntaxError: The requested module '@jridgewell/sourcemap-codec' does not provide an export named 'encode'
```
@petebacondarwin petebacondarwin force-pushed the pbd/c3/run-framework-tests-individually branch 2 times, most recently from 6addf28 to 5179b4b Compare June 30, 2025 11:54
@petebacondarwin petebacondarwin marked this pull request as ready for review June 30, 2025 14:06
@petebacondarwin petebacondarwin requested a review from a team as a code owner June 30, 2025 14:06
@petebacondarwin petebacondarwin force-pushed the pbd/c3/run-framework-tests-individually branch from 5179b4b to a4814bc Compare June 30, 2025 14:17
@cloudflare cloudflare deleted a comment from globalpressinc Jun 30, 2025
penalosa
penalosa approved these changes Jun 30, 2025
View reviewed changes
@github-project-automation github-project-automation bot moved this from Untriaged to Approved in workers-sdk Jun 30, 2025
@petebacondarwin petebacondarwin mentioned this pull request Jun 30, 2025
Closed
6 tasks
@petebacondarwin petebacondarwin force-pushed the pbd/c3/run-framework-tests-individually branch from 98a6140 to 28ddab3 Compare June 30, 2025 20:46
@petebacondarwin petebacondarwin force-pushed the pbd/c3/run-framework-tests-individually branch from 28ddab3 to a75de0f Compare June 30, 2025 20:49
@petebacondarwin petebacondarwin force-pushed the pbd/c3/run-framework-tests-individually branch from ec768d9 to 62d0d31 Compare June 30, 2025 21:43
@petebacondarwin petebacondarwin added this pull request to the merge queue Jul 1, 2025
Merged via the queue into main with commit 0a5bb5a Jul 1, 2025
31 checks passed
@petebacondarwin petebacondarwin deleted the pbd/c3/run-framework-tests-individually branch July 1, 2025 08:44
@github-project-automation github-project-automation bot moved this from Approved to Done in workers-sdk Jul 1, 2025
@workers-devprod workers-devprod mentioned this pull request Jul 1, 2025
Merged
penalosa pushed a commit that referenced this pull request Jul 1, 2025
@petebacondarwin @penalosa
refactor: run C3 e2e tests more easily locally and individually (#9533)
0d92879 
* fix: ensure that the `sourcemap-codec` library has been transformed correctly to be imported in workerd during Vitest runs

Prior to this the inline snapshot tests were failing because they use the `magic-string` library, which in turn relies upon the `sourcemap-codec` library.

This resulted in errors that look like:

```
Error running worker: SyntaxError: The requested module '@jridgewell/sourcemap-codec' does not provide an export named 'encode'
```

* refactor: run C3 e2e tests more easily locally and individually

* fixup! refactor: run C3 e2e tests more easily locally and individually

* move to-exist helper back to setup file

* rename the filtering env vars

* fixup! refactor: run C3 e2e tests more easily locally and individually

* fix c3 e2e ci groups

* remove unnecessary step

* skip gatsby on yarn

* Run windows tests in a normal directory

* skip Workers tests on Windows

* match the previous test descriptions
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@penalosa penalosa penalosa approved these changes

Assignees
No one assigned
Labels
c3-e2e Run c3 e2e tests on a PR
Projects
workers-sdk
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@petebacondarwin @penalosa @workers-devprod