Skip to content

No more emojis 🐵 #9539

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 10, 2025
Merged

No more emojis 🐵 #9539

merged 2 commits into from
Jun 10, 2025

Conversation

penalosa
Copy link
Contributor

Our E2E tests are currently failing because of an encoding bug in the production runtime inspector. A potential fix for this is rolling out, but this change should unblock us until that's ready.

Once the production change is rolled out, this PR should be reverted.


  • Tests
    • TODO (before merge)
    • Tests included
    • Tests not necessary because:
  • Wrangler / Vite E2E Tests CI Job required? (Use "e2e" label or ask maintainer to run separately)
    • I don't know
    • Required
    • Not required because:
  • Public documentation
    • TODO (before merge)
    • Cloudflare docs PR(s):
    • Documentation not necessary because: internal detail
  • Wrangler V3 Backport
    • TODO (before merge)
    • Wrangler PR:
    • Not necessary because: not a patch change

@penalosa penalosa requested a review from a team as a code owner June 10, 2025 06:55
Copy link

changeset-bot bot commented Jun 10, 2025

⚠️ No Changeset found

Latest commit: 7d4d41b

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@penalosa penalosa added e2e Run wrangler + vite-plugin e2e tests on a PR no-changeset-required labels Jun 10, 2025
@github-project-automation github-project-automation bot moved this to Untriaged in workers-sdk Jun 10, 2025
Copy link

pkg-pr-new bot commented Jun 10, 2025

create-cloudflare

npm i https://pkg.pr.new/create-cloudflare@9539

@cloudflare/kv-asset-handler

npm i https://pkg.pr.new/@cloudflare/kv-asset-handler@9539

miniflare

npm i https://pkg.pr.new/miniflare@9539

@cloudflare/pages-shared

npm i https://pkg.pr.new/@cloudflare/pages-shared@9539

@cloudflare/unenv-preset

npm i https://pkg.pr.new/@cloudflare/unenv-preset@9539

@cloudflare/vite-plugin

npm i https://pkg.pr.new/@cloudflare/vite-plugin@9539

@cloudflare/vitest-pool-workers

npm i https://pkg.pr.new/@cloudflare/vitest-pool-workers@9539

@cloudflare/workers-editor-shared

npm i https://pkg.pr.new/@cloudflare/workers-editor-shared@9539

wrangler

npm i https://pkg.pr.new/wrangler@9539

commit: 7d4d41b

@github-project-automation github-project-automation bot moved this from Untriaged to Approved in workers-sdk Jun 10, 2025
@penalosa penalosa enabled auto-merge June 10, 2025 07:00
@penalosa penalosa added this pull request to the merge queue Jun 10, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to Branch Protection failures Jun 10, 2025
You're not authorized to push to this branch. Visit "About protected branches" for more information.
@penalosa penalosa merged commit f3e1587 into main Jun 10, 2025
19 checks passed
@penalosa penalosa deleted the penalosa/fix-emoji branch June 10, 2025 07:40
@github-project-automation github-project-automation bot moved this from Approved to Done in workers-sdk Jun 10, 2025
penalosa added a commit that referenced this pull request Jun 12, 2025
This was referenced Jun 12, 2025
petebacondarwin pushed a commit that referenced this pull request Jul 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
e2e Run wrangler + vite-plugin e2e tests on a PR no-changeset-required
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants