Skip to content

test: add test cases for run_worker_first routes behaviour #9560

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jun 12, 2025

Conversation

petebacondarwin
Copy link
Contributor

Adds e2e tests for run_worker_first static routes.

  • Tests
    • TODO (before merge)
    • Tests included
    • Tests not necessary because:
  • Wrangler / Vite E2E Tests CI Job required? (Use "e2e" label or ask maintainer to run separately)
    • I don't know
    • Required
    • Not required because:
  • Public documentation
    • TODO (before merge)
    • Cloudflare docs PR(s):
    • Documentation not necessary because: tests
  • Wrangler V3 Backport
    • TODO (before merge)
    • Wrangler PR:
    • Not necessary because: new feature

@petebacondarwin petebacondarwin added e2e Run wrangler + vite-plugin e2e tests on a PR no-changeset-required labels Jun 11, 2025
Copy link

changeset-bot bot commented Jun 11, 2025

⚠️ No Changeset found

Latest commit: 02eec17

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

pkg-pr-new bot commented Jun 11, 2025

create-cloudflare

npm i https://pkg.pr.new/create-cloudflare@9560

@cloudflare/kv-asset-handler

npm i https://pkg.pr.new/@cloudflare/kv-asset-handler@9560

miniflare

npm i https://pkg.pr.new/miniflare@9560

@cloudflare/pages-shared

npm i https://pkg.pr.new/@cloudflare/pages-shared@9560

@cloudflare/unenv-preset

npm i https://pkg.pr.new/@cloudflare/unenv-preset@9560

@cloudflare/vite-plugin

npm i https://pkg.pr.new/@cloudflare/vite-plugin@9560

@cloudflare/vitest-pool-workers

npm i https://pkg.pr.new/@cloudflare/vitest-pool-workers@9560

@cloudflare/workers-editor-shared

npm i https://pkg.pr.new/@cloudflare/workers-editor-shared@9560

wrangler

npm i https://pkg.pr.new/wrangler@9560

commit: 02eec17

Copy link
Contributor

@emily-shen emily-shen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this!

@github-project-automation github-project-automation bot moved this from Untriaged to Approved in workers-sdk Jun 11, 2025
@petebacondarwin petebacondarwin force-pushed the pbd/wrangler/add-run_worker_first-e2e-tests branch 3 times, most recently from adf3d6c to df51833 Compare June 11, 2025 20:46
@petebacondarwin petebacondarwin marked this pull request as ready for review June 11, 2025 20:46
@petebacondarwin petebacondarwin requested a review from a team as a code owner June 11, 2025 20:46
@petebacondarwin petebacondarwin added the every-os Run tests (unit/e2e/c3-e2e) on every OS, rather than just macOS label Jun 11, 2025
@penalosa penalosa force-pushed the pbd/wrangler/add-run_worker_first-e2e-tests branch from 7381fd6 to 02eec17 Compare June 12, 2025 11:03
@penalosa penalosa merged commit 64e4771 into main Jun 12, 2025
25 checks passed
@penalosa penalosa deleted the pbd/wrangler/add-run_worker_first-e2e-tests branch June 12, 2025 11:55
@github-project-automation github-project-automation bot moved this from Approved to Done in workers-sdk Jun 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
e2e Run wrangler + vite-plugin e2e tests on a PR every-os Run tests (unit/e2e/c3-e2e) on every OS, rather than just macOS no-changeset-required
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants