Skip to content

Update dependencies #9561

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 8 commits into
base: main
Choose a base branch
from
Draft

Update dependencies #9561

wants to merge 8 commits into from

Conversation

penalosa
Copy link
Contributor

Update various deps:

  • tar-fs to fix audit warnings. This also involved removing the cloudflare-workers-extension code, since vsce depended on tar-fs. I removed it rather than updating vsce because it was already on the roadmap to remove this code (cc @lrapoport-cf)
  • bump vite 5 & 6 to fix audit warnings
  • bump undici to v7. Judging by the release notes for v6 & v7 I think this should be fine, but I'm mostly relying on test coverage here
  • Tests
    • TODO (before merge)
    • Tests included
    • Tests not necessary because: should be covered by existing tests
  • Wrangler / Vite E2E Tests CI Job required? (Use "e2e" label or ask maintainer to run separately)
    • I don't know
    • Required
    • Not required because:
  • Public documentation
    • TODO (before merge)
    • Cloudflare docs PR(s):
    • Documentation not necessary because: internal version bumps
  • Wrangler V3 Backport
    • TODO (before merge)
    • Wrangler PR:
    • Not necessary because: not a wrangler change

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Jun 11, 2025 •
edited
Loading

⚠️ No Changeset found

Latest commit: 1e47285

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@penalosa penalosa added e2e Run wrangler + vite-plugin e2e tests on a PR every-os Run tests (unit/e2e/c3-e2e) on every OS, rather than just macOS labels Jun 11, 2025
@penalosa penalosa force-pushed the penalosa/bump-deps branch from b770778 to 5346446 Compare June 11, 2025 17:13
@github-project-automation github-project-automation bot moved this to Untriaged in workers-sdk Jun 11, 2025
@penalosa penalosa changed the title Update depencies Update dependencies Jun 12, 2025
@pkg-pr-new pkg.pr.new
Copy link

pkg-pr-new bot commented Jun 16, 2025 •
edited
Loading

create-cloudflare

npm i https://pkg.pr.new/create-cloudflare@9561

@cloudflare/kv-asset-handler

npm i https://pkg.pr.new/@cloudflare/kv-asset-handler@9561

miniflare

npm i https://pkg.pr.new/miniflare@9561

@cloudflare/pages-shared

npm i https://pkg.pr.new/@cloudflare/pages-shared@9561

@cloudflare/unenv-preset

npm i https://pkg.pr.new/@cloudflare/unenv-preset@9561

@cloudflare/vite-plugin

npm i https://pkg.pr.new/@cloudflare/vite-plugin@9561

@cloudflare/vitest-pool-workers

npm i https://pkg.pr.new/@cloudflare/vitest-pool-workers@9561

@cloudflare/workers-editor-shared

npm i https://pkg.pr.new/@cloudflare/workers-editor-shared@9561

wrangler

npm i https://pkg.pr.new/wrangler@9561

commit: 1e47285

penalosa
penalosa commented Jun 16, 2025
View reviewed changes
fixtures/vitest-pool-workers-examples/package.json
@@ -20,7 +20,7 @@
"jose": "^5.2.2",
"miniflare": "workspace:*",
"run-script-os": "^1.1.6",
"toucan-js": "3.4.0",
"toucan-js": "3.3.1",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This intentionally unifies toucan versions across the repo

packages/wrangler/src/__tests__/init.test.ts
@@ -706,6 +706,7 @@ describe("init", () => {
});
}

// @ts-expect-error this is fine
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This an MSW types incompatibility, but I'm pretty sure it should work fine at runtime in tests. I imagine it'll likely be solved by upgrading the MSW version, but I wanted to reduce the complexities in this PR.

packages/wrangler/src/__tests__/versions/secrets/put.test.ts
@@ -380,7 +380,7 @@ describe("versions secret put", () => {
),
"module.wasm"
);

// @ts-expect-error this is fine
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This an MSW types incompatibility, but I'm pretty sure it should work fine at runtime in tests. I imagine it'll likely be solved by upgrading the MSW version, but I wanted to reduce the complexities in this PR.

packages/wrangler/src/__tests__/versions/secrets/utils.ts
@@ -104,6 +104,7 @@ function mockGetVersionContent() {
}),
"index.js"
);
// @ts-expect-error this is fine
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As above

@penalosa penalosa force-pushed the penalosa/bump-deps branch from 951a30b to 1d7c8fb Compare June 24, 2025 15:45
penalosa
penalosa commented Jun 24, 2025
View reviewed changes
package.json
@@ -74,7 +74,8 @@
"@types/react-transition-group>@types/react": "^18",
"@cloudflare/elements>@types/react": "^18",
"@types/node": "$@types/node",
"vitest>vite": "^5.0.0"
"vitest>vite": "^5.0.0",
"prebuild-install>tar-fs": "2.1.3"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pnpm is not resolving this correctly for some reason without this override. 2.1.3 is valid according to the package.json of prebuild-install

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
e2e Run wrangler + vite-plugin e2e tests on a PR every-os Run tests (unit/e2e/c3-e2e) on every OS, rather than just macOS
Projects
workers-sdk
Status: Untriaged
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@penalosa