Skip to content

Do not update container apps image if the image is unchanged #9565

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 17, 2025

Conversation

IRCody
Copy link
Contributor

@IRCody IRCody commented Jun 12, 2025

Previously we would build the image and retag even if the only change was the build-related metadata. This changes that to detect if the build has resulted in a new image, and if it has not remove the added tag and ensures the applications image is not updated.


  • Tests
    • TODO (before merge)
    • Tests included
    • Tests not necessary because:
  • Wrangler / Vite E2E Tests CI Job required? (Use "e2e" label or ask maintainer to run separately)
    • I don't know
    • Required
    • Not required because:
  • Public documentation
    • TODO (before merge)
    • Cloudflare docs PR(s):
    • Documentation not necessary because: Fixing a ux annoyance more than a real behavior change.
  • Wrangler V3 Backport
    • TODO (before merge)
    • Wrangler PR:
    • Not necessary because: Feature doesn't exist in v3.

Copy link

changeset-bot bot commented Jun 12, 2025

🦋 Changeset detected

Latest commit: e27f8df

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
wrangler Patch
@cloudflare/vitest-pool-workers Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

pkg-pr-new bot commented Jun 12, 2025

create-cloudflare

npm i https://pkg.pr.new/create-cloudflare@9565

@cloudflare/kv-asset-handler

npm i https://pkg.pr.new/@cloudflare/kv-asset-handler@9565

miniflare

npm i https://pkg.pr.new/miniflare@9565

@cloudflare/pages-shared

npm i https://pkg.pr.new/@cloudflare/pages-shared@9565

@cloudflare/unenv-preset

npm i https://pkg.pr.new/@cloudflare/unenv-preset@9565

@cloudflare/vite-plugin

npm i https://pkg.pr.new/@cloudflare/vite-plugin@9565

@cloudflare/vitest-pool-workers

npm i https://pkg.pr.new/@cloudflare/vitest-pool-workers@9565

@cloudflare/workers-editor-shared

npm i https://pkg.pr.new/@cloudflare/workers-editor-shared@9565

wrangler

npm i https://pkg.pr.new/wrangler@9565

commit: e27f8df

@IRCody IRCody force-pushed the cdr/no-push-if-identical-build branch 16 times, most recently from c501c2e to 2967694 Compare June 13, 2025 01:52
@IRCody IRCody marked this pull request as ready for review June 13, 2025 02:05
@IRCody IRCody requested review from a team as code owners June 13, 2025 02:05
@IRCody IRCody force-pushed the cdr/no-push-if-identical-build branch from 2967694 to 4b934e7 Compare June 13, 2025 19:18
Copy link
Contributor

Failed to automatically backport this PR's changes to Wrangler v3. Please manually create a PR targeting the v3-maintenance branch with your changes. Thank you for helping us keep Wrangler v3 supported!

Depending on your changes, running git rebase --onto v3-maintenance main cdr/no-push-if-identical-build might be a good starting point.

Notes:

  • your PR branch should be named v3-backport-9565
  • add the skip-v3-pr label to the current PR to stop this workflow from failing

@IRCody IRCody force-pushed the cdr/no-push-if-identical-build branch 4 times, most recently from ecb11f1 to ecca426 Compare June 13, 2025 22:25
@IRCody IRCody force-pushed the cdr/no-push-if-identical-build branch 18 times, most recently from 69b9f20 to b7035cd Compare June 17, 2025 04:46
@IRCody IRCody removed the e2e Run wrangler + vite-plugin e2e tests on a PR label Jun 17, 2025
Previously we would build the image and retag even if the only change
was the build-related metadata. This changes that to detect if the build
has resulted in a new image, and if it has not remove the added tag and
ensures the applications image is not updated.
@IRCody IRCody force-pushed the cdr/no-push-if-identical-build branch from b7035cd to e27f8df Compare June 17, 2025 05:34
@github-project-automation github-project-automation bot moved this from Untriaged to Approved in workers-sdk Jun 17, 2025
@emily-shen emily-shen added the e2e Run wrangler + vite-plugin e2e tests on a PR label Jun 17, 2025
@IRCody IRCody added this pull request to the merge queue Jun 17, 2025
Merged via the queue into main with commit b1c9139 Jun 17, 2025
36 of 38 checks passed
@IRCody IRCody deleted the cdr/no-push-if-identical-build branch June 17, 2025 15:40
@github-project-automation github-project-automation bot moved this from Approved to Done in workers-sdk Jun 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
e2e Run wrangler + vite-plugin e2e tests on a PR skip-v3-pr Skip validation of presence of a v3 backport PR
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants