Support `run_worker_first` in Vite plugin #9575

jamesopstad · 2025-06-12T10:41:53Z

Fixes #8430.
Fixes #8879.
Fixes #9109.

Support run_worker_first and static routing.

Tests
- TODO (before merge)
- Tests included
- Tests not necessary because:
Wrangler / Vite E2E Tests CI Job required? (Use "e2e" label or ask maintainer to run separately)
- I don't know
- Required
- Not required because:
Public documentation
- TODO (before merge)
- Cloudflare docs PR(s): adds new static routing options under run_worker_first cloudflare-docs#23008
- Documentation not necessary because: to follow
Wrangler V3 Backport
- TODO (before merge)
- Wrangler PR:
- Not necessary because: Not a Wrangler change

changeset-bot · 2025-06-12T10:41:57Z

🦋 Changeset detected

Latest commit: 1498a8f

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package

Name	Type
@cloudflare/vite-plugin	Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

pkg-pr-new · 2025-06-12T10:44:04Z

create-cloudflare

npm i https://pkg.pr.new/create-cloudflare@9575

@cloudflare/kv-asset-handler

npm i https://pkg.pr.new/@cloudflare/kv-asset-handler@9575

miniflare

npm i https://pkg.pr.new/miniflare@9575

@cloudflare/pages-shared

npm i https://pkg.pr.new/@cloudflare/pages-shared@9575

@cloudflare/unenv-preset

npm i https://pkg.pr.new/@cloudflare/unenv-preset@9575

@cloudflare/vite-plugin

npm i https://pkg.pr.new/@cloudflare/vite-plugin@9575

@cloudflare/vitest-pool-workers

npm i https://pkg.pr.new/@cloudflare/vitest-pool-workers@9575

@cloudflare/workers-editor-shared

npm i https://pkg.pr.new/@cloudflare/workers-editor-shared@9575

wrangler

npm i https://pkg.pr.new/wrangler@9575

commit: 1498a8f

jamesopstad · 2025-06-12T12:04:54Z

packages/vite-plugin-cloudflare/tsconfig.plugin.json

@@ -1,5 +1,5 @@
 {
-	"extends": "@cloudflare/workers-tsconfig/base.json",
+	"extends": "@cloudflare/workers-tsconfig/worker.json",


This change was necessary to prevent type errors when importing from workers-shared as workers-shared uses @cloudflare/worker-types.

Hmm. OK.
I think we should be able to avoid that... I'll have a think about it. But not blocking this PR.

petebacondarwin · 2025-06-16T07:29:06Z

packages/vite-plugin-cloudflare/playground/spa-with-api/api/index.ts

@@ -1,17 +1,30 @@
+import asset from "./asset.txt?no-inline";


Suggested change

import asset from "./asset.txt?no-inline";

import assetURL from "./asset.txt?no-inline";

or

Suggested change

import asset from "./asset.txt?no-inline";

import assetPath from "./asset.txt?no-inline";

petebacondarwin · 2025-06-16T07:50:45Z

packages/vite-plugin-cloudflare/src/index.ts

+						entryWorkerConfig.assets?.run_worker_first === true
+							? { user_worker: ["/*"] }
+							: resolvedPluginConfig.staticRouting;


How about moving this bit of logic into the plugin-config or asset-config files?

petebacondarwin · 2025-06-16T07:52:28Z

packages/vite-plugin-cloudflare/src/index.ts

+
+						preMiddleware = async (req, res, next) => {
+							// Only the URL pathname is used to match rules
+							const request = new Request(new URL(req.url!, UNKNOWN_HOST));


Is this needed? Can't you just pas req through to each matcher?

req is a Node.js http.IncomingMessage. The matchers require a Request object, even though they only use the URL pathname.

workers-sdk/packages/workers-shared/asset-worker/src/utils/rules-engine.ts

Line 151 in 70ba9fb

({ request }: { request: Request }) => {

Would be nice to change this but I guess it's for consistency with the other utils (also odd that generateStaticRoutingRuleMatcher is in the Asset Worker utils when it's only used by the Router Worker).

petebacondarwin · 2025-06-16T07:53:41Z

packages/vite-plugin-cloudflare/src/index.ts

+
+						preMiddleware = async (req, res, next) => {
+							// Only the URL pathname is used to match rules
+							const request = new Request(new URL(req.url!, UNKNOWN_HOST));


Ideally avoid ! assertions and use a runtime assertion to narrow the type:

Suggested change

const request = new Request(new URL(req.url!, UNKNOWN_HOST));

assert(req.url, "expected request URL to be defined");

const request = new Request(new URL(req.url, UNKNOWN_HOST));

petebacondarwin · 2025-06-16T08:47:46Z

packages/vite-plugin-cloudflare/tsconfig.plugin.json

@@ -1,5 +1,5 @@
 {
-	"extends": "@cloudflare/workers-tsconfig/base.json",
+	"extends": "@cloudflare/workers-tsconfig/worker.json",


Hmm. OK.
I think we should be able to avoid that... I'll have a think about it. But not blocking this PR.

… directly to entry Worker

…r messages

jamesopstad requested a review from a team as a code owner June 12, 2025 10:41

jamesopstad added the e2e Run wrangler + vite-plugin e2e tests on a PR label Jun 12, 2025

jamesopstad requested a review from a team as a code owner June 12, 2025 10:41

jamesopstad added vite-plugin Relating to the `@cloudflare/vite-plugin` package c3-e2e Run c3 e2e tests on a PR every-os Run tests (unit/e2e/c3-e2e) on every OS, rather than just macOS labels Jun 12, 2025

workers-devprod added this to workers-sdk Jun 12, 2025

github-project-automation bot moved this to Untriaged in workers-sdk Jun 12, 2025

jamesopstad changed the title ~~Support run_worker_first and static routing~~ Support run_worker_first in Vite plugin Jun 12, 2025

jamesopstad force-pushed the james/run-worker-first branch from 3876562 to 5ef4d73 Compare June 12, 2025 11:59

jamesopstad commented Jun 12, 2025

View reviewed changes

jamesopstad force-pushed the james/run-worker-first branch from 5ef4d73 to 355cc8d Compare June 12, 2025 16:49

jamesopstad requested a review from a team as a code owner June 12, 2025 16:49

jamesopstad force-pushed the james/run-worker-first branch 6 times, most recently from f08bae5 to 64ab9fe Compare June 13, 2025 13:52

petebacondarwin approved these changes Jun 16, 2025

View reviewed changes

github-project-automation bot moved this from Untriaged to Approved in workers-sdk Jun 16, 2025

jamesopstad added 7 commits June 16, 2025 16:53

Revised spa-with-api tests to include failing run_worker_first tests

80a47cb

Add additional assets playground tests

ff9e1ba

Refactor to use new createMiddleware util and send WebSocket upgrades…

a1bd221

… directly to entry Worker

Add support for static routing

d34d769

Added support for run_worker_first: true

6146bab

Added static-routing and run-worker-first variants and updated tests

b18d3f1

Add run_worker_first: true tests

86930f3

jamesopstad added 11 commits June 16, 2025 16:53

Remove run-worker-first playground

9144c92

Add changeset

204c0ba

Updates

a50dfed

Fix type errors

744ebee

Add vi.waitFor in file system test

416870a

Fix broken test

d6e3ac2

Throw rather than return errors in parseStaticRouting and update erro…

a9f83f7

…r messages

Update lock file

189cebb

Remove comment

baed763

Move pre middleware so that it is placed after viteHostCheckMiddleware

90ee001

PR feedback

1498a8f

jamesopstad force-pushed the james/run-worker-first branch from 64ab9fe to 1498a8f Compare June 16, 2025 16:01

jamesopstad added this pull request to the merge queue Jun 16, 2025

Merged via the queue into main with commit 5601fc3 Jun 16, 2025
32 of 33 checks passed

jamesopstad deleted the james/run-worker-first branch June 16, 2025 16:52

github-project-automation bot moved this from Approved to Done in workers-sdk Jun 16, 2025

workers-devprod mentioned this pull request Jun 16, 2025

Version Packages #9579

Merged

jamesopstad mentioned this pull request Jun 18, 2025

Vite plugin cloudflare worker execution order #9121

Closed

12 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Support `run_worker_first` in Vite plugin #9575

Support `run_worker_first` in Vite plugin #9575

Uh oh!

jamesopstad commented Jun 12, 2025 •

edited by lrapoport-cf

Loading

Uh oh!

changeset-bot bot commented Jun 12, 2025 •

edited

Loading

Uh oh!

pkg-pr-new bot commented Jun 12, 2025 •

edited

Loading

Uh oh!

jamesopstad Jun 12, 2025

Uh oh!

petebacondarwin Jun 16, 2025

Uh oh!

petebacondarwin Jun 16, 2025

Uh oh!

petebacondarwin Jun 16, 2025

Uh oh!

petebacondarwin Jun 16, 2025

Uh oh!

petebacondarwin Jun 16, 2025

Uh oh!

jamesopstad Jun 16, 2025

Uh oh!

petebacondarwin Jun 16, 2025

Uh oh!

petebacondarwin Jun 16, 2025

Uh oh!

Uh oh!

Uh oh!

	import asset from "./asset.txt?no-inline";
	import assetURL from "./asset.txt?no-inline";

	import asset from "./asset.txt?no-inline";
	import assetPath from "./asset.txt?no-inline";

	const request = new Request(new URL(req.url!, UNKNOWN_HOST));
	assert(req.url, "expected request URL to be defined");
	const request = new Request(new URL(req.url, UNKNOWN_HOST));

Support run_worker_first in Vite plugin #9575

Support run_worker_first in Vite plugin #9575

Uh oh!

Conversation

jamesopstad commented Jun 12, 2025 • edited by lrapoport-cf Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

changeset-bot bot commented Jun 12, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🦋 Changeset detected

Uh oh!

pkg-pr-new bot commented Jun 12, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Support `run_worker_first` in Vite plugin #9575

Support `run_worker_first` in Vite plugin #9575

jamesopstad commented Jun 12, 2025 •

edited by lrapoport-cf

Loading

changeset-bot bot commented Jun 12, 2025 •

edited

Loading

pkg-pr-new bot commented Jun 12, 2025 •

edited

Loading