Skip to content

drop unused WRANGLER_UNENV_RESOLVE_PATHS env var #9593

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 13, 2025
Merged

drop unused WRANGLER_UNENV_RESOLVE_PATHS env var #9593

merged 1 commit into from
Jun 13, 2025

Conversation

vicb
Copy link
Contributor

@vicb vicb commented Jun 13, 2025

Dropping the unused WRANGLER_UNENV_RESOLVE_PATHS

Also made nodejsHybridPlugin sync.


  • Tests
    • TODO (before merge)
    • Tests included
    • Tests not necessary because: drop unused variable
  • Wrangler / Vite E2E Tests CI Job required? (Use "e2e" label or ask maintainer to run separately)
    • I don't know
    • Required
    • Not required because:
  • Public documentation
    • TODO (before merge)
    • Cloudflare docs PR(s):
    • Documentation not necessary because: not documented
  • Wrangler V3 Backport

@vicb vicb requested review from a team as code owners June 13, 2025 07:27
Copy link

changeset-bot bot commented Jun 13, 2025

🦋 Changeset detected

Latest commit: 18d039c

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

Failed to automatically backport this PR's changes to Wrangler v3. Please manually create a PR targeting the v3-maintenance branch with your changes. Thank you for helping us keep Wrangler v3 supported!

Depending on your changes, running git rebase --onto v3-maintenance main vicb/unenv-env might be a good starting point.

@vicb vicb added e2e Run wrangler + vite-plugin e2e tests on a PR wrangler Relating to the Wrangler CLI tool labels Jun 13, 2025
Copy link

pkg-pr-new bot commented Jun 13, 2025

create-cloudflare

npm i https://pkg.pr.new/create-cloudflare@9593

@cloudflare/kv-asset-handler

npm i https://pkg.pr.new/@cloudflare/kv-asset-handler@9593

miniflare

npm i https://pkg.pr.new/miniflare@9593

@cloudflare/pages-shared

npm i https://pkg.pr.new/@cloudflare/pages-shared@9593

@cloudflare/unenv-preset

npm i https://pkg.pr.new/@cloudflare/unenv-preset@9593

@cloudflare/vite-plugin

npm i https://pkg.pr.new/@cloudflare/vite-plugin@9593

@cloudflare/vitest-pool-workers

npm i https://pkg.pr.new/@cloudflare/vitest-pool-workers@9593

@cloudflare/workers-editor-shared

npm i https://pkg.pr.new/@cloudflare/workers-editor-shared@9593

wrangler

npm i https://pkg.pr.new/wrangler@9593

commit: 18d039c

Copy link
Contributor

@petebacondarwin petebacondarwin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love it!

@github-project-automation github-project-automation bot moved this from Untriaged to Approved in workers-sdk Jun 13, 2025
@vicb vicb added the skip-v3-pr Skip validation of presence of a v3 backport PR label Jun 13, 2025
@vicb vicb added this pull request to the merge queue Jun 13, 2025
Merged via the queue into main with commit cf33417 Jun 13, 2025
55 of 69 checks passed
@vicb vicb deleted the vicb/unenv-env branch June 13, 2025 12:12
@github-project-automation github-project-automation bot moved this from Approved to Done in workers-sdk Jun 13, 2025
jseba added a commit to jseba/workers-sdk that referenced this pull request Jun 14, 2025
* 'main' of ssh://github.com/cloudflare/workers-sdk: (213 commits)
  fix(vite-plugin-cloudflare): allow unknown entrypoint on startup (cloudflare#9583)
  add warning about env not specified to potentially risky wrangler commands (cloudflare#9344)
  test: correctly delete test d1 databases (cloudflare#9598)
  Add details to v3 maintenance worflow error message (cloudflare#9602)
  drop unused `WRANGLER_UNENV_RESOLVE_PATHS` env var (cloudflare#9593)
  warn instead of erroring if no exposed ports. and remove unused dev_exposed_ports (cloudflare#9573)
  fix(wrangler): point to the right doc location (replaces cloudflare#9353) (cloudflare#9592)
  [vitest-pool-worker] Add `type: module` in package.json (cloudflare#9595)
  Enable HTML handling for HTML files in the public directory (cloudflare#9548)
  switch from go container to js (cloudflare#9588)
  containers: switch to Cloudflare container registry (cloudflare#9564)
  performance improvement: restart a mixed mode session only if the worker's remote bindings have changed (cloudflare#9536)
  ci: delete more orphaned resources from e2e tests (cloudflare#9580)
  test: remove `verifyBuildScript` logic from c3 e2e tests (cloudflare#9504)
  fix(vite-plugin): ensure node compat globals are injected before any imports (cloudflare#9581)
  feat(containers-shared): Move `isDockerfile` utility function to `containers-shared` (cloudflare#9577)
  allow `startWorker` to accept `false` as an `inspector` option (to disable the inspector server) (cloudflare#9550)
  Update capnp generated code from the workerd.capnp (cloudflare#9582)
  Bump `@cloudflare/unenv-preset` to 2.3.3 (cloudflare#9566)
  test: make custom build bundling tests more robust (cloudflare#9494)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
e2e Run wrangler + vite-plugin e2e tests on a PR skip-v3-pr Skip validation of presence of a v3 backport PR wrangler Relating to the Wrangler CLI tool
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants