Skip to content

Add details to v3 maintenance worflow error message #9602

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 13, 2025
Merged

Add details to v3 maintenance worflow error message #9602

merged 1 commit into from
Jun 13, 2025

Conversation

vicb
Copy link
Contributor

@vicb vicb commented Jun 13, 2025 •
edited
Loading

Fixes my frustartion (WIP).

  • The v3 backport PR branch is expected to follow a given pattern so document that
  • The v3 workflow will keep failing until you had skip-v3-pr so document that
  • Tests
    • TODO (before merge)
    • Tests included
    • Tests not necessary because: CI
  • Wrangler / Vite E2E Tests CI Job required? (Use "e2e" label or ask maintainer to run separately)
    • I don't know
    • Required
    • Not required because: CI
  • Public documentation
    • TODO (before merge)
    • Cloudflare docs PR(s):
    • Documentation not necessary because: Do we ever need doc :)
  • Wrangler V3 Backport
    • TODO (before merge)
    • Wrangler PR:
    • Not necessary because: CI

@vicb vicb requested a review from a team as a code owner June 13, 2025 12:35
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Jun 13, 2025 •
edited
Loading

⚠️ No Changeset found

Latest commit: 51a8e4e

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-project-automation github-project-automation bot moved this to Untriaged in workers-sdk Jun 13, 2025
@pkg-pr-new pkg.pr.new
Copy link

pkg-pr-new bot commented Jun 13, 2025 •
edited
Loading

create-cloudflare

npm i https://pkg.pr.new/create-cloudflare@9602

@cloudflare/kv-asset-handler

npm i https://pkg.pr.new/@cloudflare/kv-asset-handler@9602

miniflare

npm i https://pkg.pr.new/miniflare@9602

@cloudflare/pages-shared

npm i https://pkg.pr.new/@cloudflare/pages-shared@9602

@cloudflare/unenv-preset

npm i https://pkg.pr.new/@cloudflare/unenv-preset@9602

@cloudflare/vite-plugin

npm i https://pkg.pr.new/@cloudflare/vite-plugin@9602

@cloudflare/vitest-pool-workers

npm i https://pkg.pr.new/@cloudflare/vitest-pool-workers@9602

@cloudflare/workers-editor-shared

npm i https://pkg.pr.new/@cloudflare/workers-editor-shared@9602

wrangler

npm i https://pkg.pr.new/wrangler@9602

commit: 51a8e4e

@github-project-automation github-project-automation bot moved this from Untriaged to Approved in workers-sdk Jun 13, 2025
penalosa
penalosa reviewed Jun 13, 2025
View reviewed changes
@vicb
Copy link
Contributor Author

vicb commented Jun 13, 2025

Thanks for the reviews 🎉

@vicb vicb added this pull request to the merge queue Jun 13, 2025
Merged via the queue into main with commit 96f14f6 Jun 13, 2025
27 checks passed
@vicb vicb deleted the vicb/ci-v3 branch June 13, 2025 14:13
@github-project-automation github-project-automation bot moved this from Approved to Done in workers-sdk Jun 13, 2025
jseba added a commit to jseba/workers-sdk that referenced this pull request Jun 14, 2025
@jseba
Merge branch 'main' of ssh://github.com/cloudflare/workers-sdk into HEAD
50e2835 
* 'main' of ssh://github.com/cloudflare/workers-sdk: (213 commits)
  fix(vite-plugin-cloudflare): allow unknown entrypoint on startup (cloudflare#9583)
  add warning about env not specified to potentially risky wrangler commands (cloudflare#9344)
  test: correctly delete test d1 databases (cloudflare#9598)
  Add details to v3 maintenance worflow error message (cloudflare#9602)
  drop unused `WRANGLER_UNENV_RESOLVE_PATHS` env var (cloudflare#9593)
  warn instead of erroring if no exposed ports. and remove unused dev_exposed_ports (cloudflare#9573)
  fix(wrangler): point to the right doc location (replaces cloudflare#9353) (cloudflare#9592)
  [vitest-pool-worker] Add `type: module` in package.json (cloudflare#9595)
  Enable HTML handling for HTML files in the public directory (cloudflare#9548)
  switch from go container to js (cloudflare#9588)
  containers: switch to Cloudflare container registry (cloudflare#9564)
  performance improvement: restart a mixed mode session only if the worker's remote bindings have changed (cloudflare#9536)
  ci: delete more orphaned resources from e2e tests (cloudflare#9580)
  test: remove `verifyBuildScript` logic from c3 e2e tests (cloudflare#9504)
  fix(vite-plugin): ensure node compat globals are injected before any imports (cloudflare#9581)
  feat(containers-shared): Move `isDockerfile` utility function to `containers-shared` (cloudflare#9577)
  allow `startWorker` to accept `false` as an `inspector` option (to disable the inspector server) (cloudflare#9550)
  Update capnp generated code from the workerd.capnp (cloudflare#9582)
  Bump `@cloudflare/unenv-preset` to 2.3.3 (cloudflare#9566)
  test: make custom build bundling tests more robust (cloudflare#9494)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@petebacondarwin petebacondarwin petebacondarwin approved these changes

@penalosa penalosa penalosa left review comments

Assignees
No one assigned
Labels
no-changeset-required
Projects
workers-sdk
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vicb @petebacondarwin @penalosa