Skip to content

remove todo comment left in changelog by mistake #9624

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 17, 2025

Conversation

dario-piotrowicz
Copy link
Member

@dario-piotrowicz dario-piotrowicz commented Jun 17, 2025

Changelog fix for #9344

  • Tests
    • TODO (before merge)
    • Tests included
    • Tests not necessary because: changelog fix
  • Wrangler / Vite E2E Tests CI Job required? (Use "e2e" label or ask maintainer to run separately)
    • I don't know
    • Required
    • Not required because: changelog fix
  • Public documentation
    • TODO (before merge)
    • Cloudflare docs PR(s):
    • Documentation not necessary because: changelog fix
  • Wrangler V3 Backport
    • TODO (before merge)
    • Wrangler PR:
    • Not necessary because: changelog fix

@dario-piotrowicz dario-piotrowicz added the skip-v3-pr Skip validation of presence of a v3 backport PR label Jun 17, 2025
Copy link

changeset-bot bot commented Jun 17, 2025

⚠️ No Changeset found

Latest commit: 846ecbe

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes changesets to release 2 packages
Name Type
wrangler Patch
@cloudflare/vitest-pool-workers Patch

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

pkg-pr-new bot commented Jun 17, 2025

create-cloudflare

npm i https://pkg.pr.new/create-cloudflare@9624

@cloudflare/kv-asset-handler

npm i https://pkg.pr.new/@cloudflare/kv-asset-handler@9624

miniflare

npm i https://pkg.pr.new/miniflare@9624

@cloudflare/pages-shared

npm i https://pkg.pr.new/@cloudflare/pages-shared@9624

@cloudflare/unenv-preset

npm i https://pkg.pr.new/@cloudflare/unenv-preset@9624

@cloudflare/vite-plugin

npm i https://pkg.pr.new/@cloudflare/vite-plugin@9624

@cloudflare/vitest-pool-workers

npm i https://pkg.pr.new/@cloudflare/vitest-pool-workers@9624

@cloudflare/workers-editor-shared

npm i https://pkg.pr.new/@cloudflare/workers-editor-shared@9624

wrangler

npm i https://pkg.pr.new/wrangler@9624

commit: 846ecbe

@github-project-automation github-project-automation bot moved this from Untriaged to Approved in workers-sdk Jun 17, 2025
@CarmenPopoviciu CarmenPopoviciu merged commit 746ce45 into main Jun 17, 2025
31 of 35 checks passed
@CarmenPopoviciu CarmenPopoviciu deleted the todo-manually-test-changelog-remove branch June 17, 2025 10:40
@github-project-automation github-project-automation bot moved this from Approved to Done in workers-sdk Jun 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip-v3-pr Skip validation of presence of a v3 backport PR
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants