Skip to content

fix changeset #9651

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 18, 2025
Merged

fix changeset #9651

merged 2 commits into from
Jun 18, 2025
+0 −2

Conversation

CarmenPopoviciu
Copy link
Contributor

@CarmenPopoviciu CarmenPopoviciu commented Jun 18, 2025 •
edited
Loading

  • Tests
    • TODO (before merge)
    • Tests included
    • Tests not necessary because: changeset change
  • Wrangler / Vite E2E Tests CI Job required? (Use "e2e" label or ask maintainer to run separately)
    • I don't know
    • Required
    • Not required because: changeset change
  • Public documentation
    • TODO (before merge)
    • Cloudflare docs PR(s):
    • Documentation not necessary because: changeset change
  • Wrangler V3 Backport
    • TODO (before merge)
    • Wrangler PR:
    • Not necessary because: changeset change

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Jun 18, 2025 •
edited
Loading

⚠️ No Changeset found

Latest commit: 5438533

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes changesets to release 2 packages
Name Type
wrangler Patch
@cloudflare/vitest-pool-workers Patch

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-project-automation github-project-automation bot moved this to Untriaged in workers-sdk Jun 18, 2025
@CarmenPopoviciu CarmenPopoviciu added skip-pr-description-validation Skip validation of the required PR description format skip-v3-pr Skip validation of presence of a v3 backport PR labels Jun 18, 2025
@github-actions GitHub Actions
Copy link
Contributor

Failed to automatically backport this PR's changes to Wrangler v3. Please manually create a PR targeting the v3-maintenance branch with your changes. Thank you for helping us keep Wrangler v3 supported!

Depending on your changes, running git rebase --onto v3-maintenance main carmen/fix-changeset might be a good starting point.

Notes:

  • your PR branch should be named v3-backport-9651
  • add the skip-v3-pr label to the current PR to stop this workflow from failing

@pkg-pr-new pkg.pr.new
Copy link

pkg-pr-new bot commented Jun 18, 2025 •
edited
Loading

create-cloudflare

npm i https://pkg.pr.new/create-cloudflare@9651

@cloudflare/kv-asset-handler

npm i https://pkg.pr.new/@cloudflare/kv-asset-handler@9651

miniflare

npm i https://pkg.pr.new/miniflare@9651

@cloudflare/pages-shared

npm i https://pkg.pr.new/@cloudflare/pages-shared@9651

@cloudflare/unenv-preset

npm i https://pkg.pr.new/@cloudflare/unenv-preset@9651

@cloudflare/vite-plugin

npm i https://pkg.pr.new/@cloudflare/vite-plugin@9651

@cloudflare/vitest-pool-workers

npm i https://pkg.pr.new/@cloudflare/vitest-pool-workers@9651

@cloudflare/workers-editor-shared

npm i https://pkg.pr.new/@cloudflare/workers-editor-shared@9651

wrangler

npm i https://pkg.pr.new/wrangler@9651

commit: 5438533

@CarmenPopoviciu CarmenPopoviciu requested a review from a team as a code owner June 18, 2025 14:50
@github-project-automation github-project-automation bot moved this from Untriaged to Approved in workers-sdk Jun 18, 2025
petebacondarwin
petebacondarwin approved these changes Jun 18, 2025
View reviewed changes
packages/containers-shared/package.json
@@ -17,7 +17,6 @@
"scripts": {
"check:lint": "eslint src --ext ts",
"check:type": "tsc -p ./tsconfig.json && pnpm run type:tests",
"deploy": "echo 'no deploy'",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When was this added? It should have broken the tools/deployments/__tests__/deploy-non-npm-packages.test.ts test.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

apparently Emily added it here: 4b228a7. I am not sure why tests didn't fail. Maybe same reason as what I was discussing today about ci tests hitting cache?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

VP PR tests caught this: https://github.com/cloudflare/workers-sdk/actions/runs/15735662603/job/44347571994?pr=9650. But even there I am not 100% sure why the test only fails on Linux. Are we not running this test on all OSs?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's because we only run the tools tests on the Linux OS in the Version Packages PR - and not on normal PRs!!

@CarmenPopoviciu CarmenPopoviciu merged commit a7bc741 into main Jun 18, 2025
26 checks passed
@CarmenPopoviciu CarmenPopoviciu deleted the carmen/fix-changeset branch June 18, 2025 15:14
@github-project-automation github-project-automation bot moved this from Approved to Done in workers-sdk Jun 18, 2025
jseba added a commit to jseba/workers-sdk that referenced this pull request Jun 18, 2025
@jseba
Merge branch 'main' of ssh://github.com/cloudflare/workers-sdk into j…
d4f7f8b 
…seba/containers_scope

* 'main' of ssh://github.com/cloudflare/workers-sdk: (31 commits)
  Refactor preview mode and ensure compatibility with Vite 7 (cloudflare#9647)
  Block requests vulnerable to opennext vulnerability (cloudflare#9635)
  Add test for cloudchamber buildAndMaybePush (cloudflare#9638)
  chore: remove redundant binding guide superseded by internal docs (cloudflare#9648)
  add changeset to trigger release of workers/pages projects (cloudflare#9649)
  Add @handler to Python templates. (cloudflare#9305)
  Migrate from unbuild to obuild (cloudflare#9243)
  Version Packages (cloudflare#9650)
  fix changeset (cloudflare#9651)
  containers: Default scheduling policy should be the default (cloudflare#9621)
  Rename Mixed Mode to remote proxy/remote bindings depending on context (cloudflare#9586)
  Version Packages (cloudflare#9632)
  Correctly mock out getDockerImageDigest for testing buildAndMaybePush (cloudflare#9636)
  [C3] Bump create-remix from 2.16.6 to 2.16.8 in /packages/create-cloudflare/src/frameworks (cloudflare#9525)
  Remove "Cloudchamber" from user facing error messages (cloudflare#9628)
  sync local containers with latest workerd (cloudflare#9576)
  Bump the workerd-and-workers-types group with 2 updates (cloudflare#9591)
  [C3] Bump gatsby from 5.14.3 to 5.14.4 in /packages/create-cloudflare/src/frameworks (cloudflare#9524)
  [C3] Bump create-react-router from 7.6.1 to 7.6.2 in /packages/create-cloudflare/src/frameworks (cloudflare#9526)
  [C3] Bump create-docusaurus from 3.8.0 to 3.8.1 in /packages/create-cloudflare/src/frameworks (cloudflare#9527)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@petebacondarwin petebacondarwin petebacondarwin approved these changes

Assignees
No one assigned
Labels
skip-pr-description-validation Skip validation of the required PR description format skip-v3-pr Skip validation of presence of a v3 backport PR
Projects
workers-sdk
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@CarmenPopoviciu @petebacondarwin