Skip to content

re-enable vite-plugin remote bindings e2e tests #9652

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

dario-piotrowicz
Copy link
Member

Fixes https://jira.cfdata.org/browse/DEVX-1953


  • Tests
    • TODO (before merge)
    • Tests included
    • Tests not necessary because:
  • Wrangler / Vite E2E Tests CI Job required? (Use "e2e" label or ask maintainer to run separately)
    • I don't know
    • Required
    • Not required because:
  • Public documentation
    • TODO (before merge)
    • Cloudflare docs PR(s):
    • Documentation not necessary because: tests-only change
  • Wrangler V3 Backport
    • TODO (before merge)
    • Wrangler PR:
    • Not necessary because: update related to a non-v3 feature

@dario-piotrowicz dario-piotrowicz requested review from a team as code owners June 18, 2025 14:50
@dario-piotrowicz dario-piotrowicz added e2e Run wrangler + vite-plugin e2e tests on a PR no-changeset-required skip-v3-pr Skip validation of presence of a v3 backport PR every-os Run tests (unit/e2e/c3-e2e) on every OS, rather than just macOS labels Jun 18, 2025
Copy link

changeset-bot bot commented Jun 18, 2025

⚠️ No Changeset found

Latest commit: 7ec807a

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

pkg-pr-new bot commented Jun 18, 2025

create-cloudflare

npm i https://pkg.pr.new/create-cloudflare@9652

@cloudflare/kv-asset-handler

npm i https://pkg.pr.new/@cloudflare/kv-asset-handler@9652

miniflare

npm i https://pkg.pr.new/miniflare@9652

@cloudflare/pages-shared

npm i https://pkg.pr.new/@cloudflare/pages-shared@9652

@cloudflare/unenv-preset

npm i https://pkg.pr.new/@cloudflare/unenv-preset@9652

@cloudflare/vite-plugin

npm i https://pkg.pr.new/@cloudflare/vite-plugin@9652

@cloudflare/vitest-pool-workers

npm i https://pkg.pr.new/@cloudflare/vitest-pool-workers@9652

@cloudflare/workers-editor-shared

npm i https://pkg.pr.new/@cloudflare/workers-editor-shared@9652

wrangler

npm i https://pkg.pr.new/wrangler@9652

commit: 7ec807a

@dario-piotrowicz dario-piotrowicz force-pushed the dario/DEVX-1953/re-enable-mixed-mode-vite-e2es branch from 16dd719 to d747ec7 Compare June 18, 2025 15:32
@dario-piotrowicz dario-piotrowicz force-pushed the dario/DEVX-1953/re-enable-mixed-mode-vite-e2es branch from 60524b1 to 3a494b5 Compare June 18, 2025 21:56
@dario-piotrowicz dario-piotrowicz marked this pull request as draft June 18, 2025 23:36
@dario-piotrowicz dario-piotrowicz force-pushed the dario/DEVX-1953/re-enable-mixed-mode-vite-e2es branch from eef5785 to 7ec807a Compare June 20, 2025 11:01
@dario-piotrowicz dario-piotrowicz marked this pull request as ready for review June 20, 2025 12:36
Copy link
Contributor

@petebacondarwin petebacondarwin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should also skip remote bindings tests if there is no CLOUDFLARE_API_TOKEN. That way we won't block forked PRs.

@petebacondarwin petebacondarwin marked this pull request as draft July 2, 2025 11:38
@dario-piotrowicz
Copy link
Member Author

I think we should also skip remote bindings tests if there is no CLOUDFLARE_API_TOKEN. That way we won't block forked PRs.

We are: https://github.com/cloudflare/workers-sdk/pull/9652/files#diff-d9b32f69a202cbf69dc77c2777a78758abe37967f4015456c65d005d6117c33dR21

Are we not? 🤔

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
e2e Run wrangler + vite-plugin e2e tests on a PR every-os Run tests (unit/e2e/c3-e2e) on every OS, rather than just macOS no-changeset-required skip-v3-pr Skip validation of presence of a v3 backport PR
Projects
Status: Untriaged
Development

Successfully merging this pull request may close these issues.

2 participants