-
Notifications
You must be signed in to change notification settings - Fork 925
re-enable vite-plugin remote bindings e2e tests #9652
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
re-enable vite-plugin remote bindings e2e tests #9652
Conversation
|
create-cloudflare
@cloudflare/kv-asset-handler
miniflare
@cloudflare/pages-shared
@cloudflare/unenv-preset
@cloudflare/vite-plugin
@cloudflare/vitest-pool-workers
@cloudflare/workers-editor-shared
wrangler
commit: |
16dd719
to
d747ec7
Compare
60524b1
to
3a494b5
Compare
eef5785
to
7ec807a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should also skip remote bindings tests if there is no CLOUDFLARE_API_TOKEN. That way we won't block forked PRs.
Are we not? 🤔 |
Fixes https://jira.cfdata.org/browse/DEVX-1953