Skip to content

Containers fixups #9653

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jun 19, 2025
Merged

Containers fixups #9653

merged 6 commits into from
Jun 19, 2025

Conversation

penalosa
Copy link
Contributor

Fixes https://jira.cfdata.org/browse/DEVX-1988 & https://jira.cfdata.org/browse/DEVX-1999

  • Rename the env var for customising the docker bin location to WRANGLER_DOCKER_BIN
  • Add a warning banner to all containers & cloudchamber commands

  • Tests
    • TODO (before merge)
    • Tests included
    • Tests not necessary because: should pass existing tests
  • Wrangler / Vite E2E Tests CI Job required? (Use "e2e" label or ask maintainer to run separately)
    • I don't know
    • Required
    • Not required because:
  • Public documentation
    • TODO (before merge)
    • Cloudflare docs PR(s):
    • Documentation not necessary because: still pre-release
  • Wrangler V3 Backport
    • TODO (before merge)
    • Wrangler PR:
    • Not necessary because: v4-only fature

@penalosa penalosa requested review from a team as code owners June 18, 2025 14:50
Copy link

changeset-bot bot commented Jun 18, 2025

🦋 Changeset detected

Latest commit: 85ff6fc

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@cloudflare/containers-shared Patch
wrangler Patch
@cloudflare/vitest-pool-workers Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-project-automation github-project-automation bot moved this to Untriaged in workers-sdk Jun 18, 2025
@workers-devprod workers-devprod added the e2e Run wrangler + vite-plugin e2e tests on a PR label Jun 18, 2025
Copy link

pkg-pr-new bot commented Jun 18, 2025

create-cloudflare

npm i https://pkg.pr.new/create-cloudflare@9653

@cloudflare/kv-asset-handler

npm i https://pkg.pr.new/@cloudflare/kv-asset-handler@9653

miniflare

npm i https://pkg.pr.new/miniflare@9653

@cloudflare/pages-shared

npm i https://pkg.pr.new/@cloudflare/pages-shared@9653

@cloudflare/unenv-preset

npm i https://pkg.pr.new/@cloudflare/unenv-preset@9653

@cloudflare/vite-plugin

npm i https://pkg.pr.new/@cloudflare/vite-plugin@9653

@cloudflare/vitest-pool-workers

npm i https://pkg.pr.new/@cloudflare/vitest-pool-workers@9653

@cloudflare/workers-editor-shared

npm i https://pkg.pr.new/@cloudflare/workers-editor-shared@9653

wrangler

npm i https://pkg.pr.new/wrangler@9653

commit: 85ff6fc

Copy link
Contributor

Failed to automatically backport this PR's changes to Wrangler v3. Please manually create a PR targeting the v3-maintenance branch with your changes. Thank you for helping us keep Wrangler v3 supported!

Depending on your changes, running git rebase --onto v3-maintenance main penalosa/containers might be a good starting point.

Notes:

  • your PR branch should be named v3-backport-9653
  • add the skip-v3-pr label to the current PR to stop this workflow from failing

@penalosa penalosa added the skip-v3-pr Skip validation of presence of a v3 backport PR label Jun 18, 2025
@github-project-automation github-project-automation bot moved this from Untriaged to Approved in workers-sdk Jun 18, 2025
@penalosa penalosa enabled auto-merge June 18, 2025 16:47
@CarmenPopoviciu CarmenPopoviciu disabled auto-merge June 19, 2025 14:54
@CarmenPopoviciu CarmenPopoviciu merged commit 8a60fe7 into main Jun 19, 2025
21 of 23 checks passed
@CarmenPopoviciu CarmenPopoviciu deleted the penalosa/containers branch June 19, 2025 14:54
@github-project-automation github-project-automation bot moved this from Approved to Done in workers-sdk Jun 19, 2025
@@ -68,6 +68,7 @@ export const registriesCommand = (yargs: CommonYargsArgvJSON) => {
(args) => configureImageRegistryOptionalYargs(args),
(args) =>
handleFailure(
`wrangler cloudchamber registries configure`,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm pretty sure this string can be computed from the command config rather than duplicating it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
e2e Run wrangler + vite-plugin e2e tests on a PR skip-v3-pr Skip validation of presence of a v3 backport PR
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

5 participants