Skip to content

chore: test hello world binding support in vitest-pool-workers #9662

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 19, 2025

Conversation

edmundhung
Copy link
Member

Fixes DEVX-1775

This adds an example smoke test to verify if the local binding works in vitest-pool-workers


  • Tests
    • TODO (before merge)
    • Tests included
    • Tests not necessary because:
  • Wrangler / Vite E2E Tests CI Job required? (Use "e2e" label or ask maintainer to run separately)
    • I don't know
    • Required
    • Not required because: only added non e2e test in this PR
  • Public documentation
    • TODO (before merge)
    • Cloudflare docs PR(s):
    • Documentation not necessary because: no feature changes
  • Wrangler V3 Backport
    • TODO (before merge)
    • Wrangler PR:
    • Not necessary because: only added test

@edmundhung edmundhung requested a review from a team as a code owner June 18, 2025 17:40
Copy link

changeset-bot bot commented Jun 18, 2025

⚠️ No Changeset found

Latest commit: ea59157

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

pkg-pr-new bot commented Jun 18, 2025

create-cloudflare

npm i https://pkg.pr.new/create-cloudflare@9662

@cloudflare/kv-asset-handler

npm i https://pkg.pr.new/@cloudflare/kv-asset-handler@9662

miniflare

npm i https://pkg.pr.new/miniflare@9662

@cloudflare/pages-shared

npm i https://pkg.pr.new/@cloudflare/pages-shared@9662

@cloudflare/unenv-preset

npm i https://pkg.pr.new/@cloudflare/unenv-preset@9662

@cloudflare/vite-plugin

npm i https://pkg.pr.new/@cloudflare/vite-plugin@9662

@cloudflare/vitest-pool-workers

npm i https://pkg.pr.new/@cloudflare/vitest-pool-workers@9662

@cloudflare/workers-editor-shared

npm i https://pkg.pr.new/@cloudflare/workers-editor-shared@9662

wrangler

npm i https://pkg.pr.new/wrangler@9662

commit: ea59157

@github-project-automation github-project-automation bot moved this from Untriaged to Approved in workers-sdk Jun 19, 2025
@CarmenPopoviciu CarmenPopoviciu merged commit b43bf4f into main Jun 19, 2025
29 of 33 checks passed
@github-project-automation github-project-automation bot moved this from Approved to Done in workers-sdk Jun 19, 2025
@CarmenPopoviciu CarmenPopoviciu deleted the edmundhung/vpw-binding-tests branch June 19, 2025 07:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants