Skip to content

chore: Run C3 e2e tests on every OS only if both every-os and c3-e2e labels are applied #9671

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 19, 2025

Conversation

CarmenPopoviciu
Copy link
Contributor

@CarmenPopoviciu CarmenPopoviciu commented Jun 19, 2025

e2e tests are run on every OS if both the e2e and every-os labels are set. The same is not true atm for C3 e2e tests. This PR fixes that.

Fixes n/a


  • Tests
    • TODO (before merge)
    • Tests included
    • Tests not necessary because: GH workflow changes
  • Wrangler / Vite E2E Tests CI Job required? (Use "e2e" label or ask maintainer to run separately)
    • I don't know
    • Required
    • Not required because: GH workflow changes
  • Public documentation
    • TODO (before merge)
    • Cloudflare docs PR(s):
    • Documentation not necessary because: GH workflow changes
  • Wrangler V3 Backport
    • TODO (before merge)
    • Wrangler PR:
    • Not necessary because: GH workflow changes

@CarmenPopoviciu CarmenPopoviciu requested a review from a team as a code owner June 19, 2025 08:30
Copy link

changeset-bot bot commented Jun 19, 2025

⚠️ No Changeset found

Latest commit: 95d8463

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@CarmenPopoviciu CarmenPopoviciu added the skip-v3-pr Skip validation of presence of a v3 backport PR label Jun 19, 2025
Copy link

pkg-pr-new bot commented Jun 19, 2025

create-cloudflare

npm i https://pkg.pr.new/create-cloudflare@9671

@cloudflare/kv-asset-handler

npm i https://pkg.pr.new/@cloudflare/kv-asset-handler@9671

miniflare

npm i https://pkg.pr.new/miniflare@9671

@cloudflare/pages-shared

npm i https://pkg.pr.new/@cloudflare/pages-shared@9671

@cloudflare/unenv-preset

npm i https://pkg.pr.new/@cloudflare/unenv-preset@9671

@cloudflare/vite-plugin

npm i https://pkg.pr.new/@cloudflare/vite-plugin@9671

@cloudflare/vitest-pool-workers

npm i https://pkg.pr.new/@cloudflare/vitest-pool-workers@9671

@cloudflare/workers-editor-shared

npm i https://pkg.pr.new/@cloudflare/workers-editor-shared@9671

wrangler

npm i https://pkg.pr.new/wrangler@9671

commit: 95d8463

@CarmenPopoviciu CarmenPopoviciu marked this pull request as draft June 19, 2025 08:47
@CarmenPopoviciu CarmenPopoviciu marked this pull request as ready for review June 19, 2025 08:47
@CarmenPopoviciu CarmenPopoviciu force-pushed the carmen/run-unit-tests-on-every-os branch from 696112b to c911d7b Compare June 19, 2025 08:59
@CarmenPopoviciu CarmenPopoviciu changed the title chore: Add label to run unit tests on multiple OSs chore: Run C3 e2e tests on every OS only if both every-os and c3-e2e labels are applied Jun 19, 2025
@CarmenPopoviciu CarmenPopoviciu force-pushed the carmen/run-unit-tests-on-every-os branch from c911d7b to 95d8463 Compare June 19, 2025 09:04
@github-project-automation github-project-automation bot moved this to Untriaged in workers-sdk Jun 19, 2025
@CarmenPopoviciu CarmenPopoviciu merged commit 9d778ce into main Jun 19, 2025
20 checks passed
@CarmenPopoviciu CarmenPopoviciu deleted the carmen/run-unit-tests-on-every-os branch June 19, 2025 09:13
@github-project-automation github-project-automation bot moved this from Untriaged to Done in workers-sdk Jun 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-changeset-required skip-v3-pr Skip validation of presence of a v3 backport PR
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants