Skip to content

fix: ensure that wrangler deploy and version upload don't override the remote-bindings flag #9673

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 19, 2025

Conversation

dario-piotrowicz
Copy link
Member

@dario-piotrowicz dario-piotrowicz commented Jun 19, 2025

Currently wrangler deploy --x-remote-bindings shows incorrect warnings regarding experimental_remote fields:

Screenshot 2025-06-19 at 10 01 47

The changes here are addressing this


  • Tests
    • TODO (before merge)
    • Tests included
    • Tests not necessary because: I'd love it to land this in the next release I can add the tests as a followup if that's ok
  • Wrangler / Vite E2E Tests CI Job required? (Use "e2e" label or ask maintainer to run separately)
    • I don't know
    • Required
    • Not required because:
  • Public documentation
    • TODO (before merge)
    • Cloudflare docs PR(s):
    • Documentation not necessary because: I need to discuss this with the team
  • Wrangler V3 Backport
    • TODO (before merge)
    • Wrangler PR:
    • Not necessary because: not a wrangler v3 feature

@dario-piotrowicz dario-piotrowicz requested a review from a team as a code owner June 19, 2025 09:34
Copy link

changeset-bot bot commented Jun 19, 2025

🦋 Changeset detected

Latest commit: 5c072a0

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
wrangler Patch
@cloudflare/vitest-pool-workers Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-project-automation github-project-automation bot moved this to Untriaged in workers-sdk Jun 19, 2025
@dario-piotrowicz dario-piotrowicz added e2e Run wrangler + vite-plugin e2e tests on a PR skip-v3-pr Skip validation of presence of a v3 backport PR labels Jun 19, 2025
Copy link
Contributor

Failed to automatically backport this PR's changes to Wrangler v3. Please manually create a PR targeting the v3-maintenance branch with your changes. Thank you for helping us keep Wrangler v3 supported!

Depending on your changes, running git rebase --onto v3-maintenance main dario/respect-remote-bindings-flag might be a good starting point.

Notes:

  • your PR branch should be named v3-backport-9673
  • add the skip-v3-pr label to the current PR to stop this workflow from failing

Copy link

pkg-pr-new bot commented Jun 19, 2025

create-cloudflare

npm i https://pkg.pr.new/create-cloudflare@9673

@cloudflare/kv-asset-handler

npm i https://pkg.pr.new/@cloudflare/kv-asset-handler@9673

miniflare

npm i https://pkg.pr.new/miniflare@9673

@cloudflare/pages-shared

npm i https://pkg.pr.new/@cloudflare/pages-shared@9673

@cloudflare/unenv-preset

npm i https://pkg.pr.new/@cloudflare/unenv-preset@9673

@cloudflare/vite-plugin

npm i https://pkg.pr.new/@cloudflare/vite-plugin@9673

@cloudflare/vitest-pool-workers

npm i https://pkg.pr.new/@cloudflare/vitest-pool-workers@9673

@cloudflare/workers-editor-shared

npm i https://pkg.pr.new/@cloudflare/workers-editor-shared@9673

wrangler

npm i https://pkg.pr.new/wrangler@9673

commit: 5c072a0

Copy link
Contributor

@CarmenPopoviciu CarmenPopoviciu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you for fixing this 🙏

@github-project-automation github-project-automation bot moved this from Untriaged to Approved in workers-sdk Jun 19, 2025
@CarmenPopoviciu CarmenPopoviciu added the every-os Run tests (unit/e2e/c3-e2e) on every OS, rather than just macOS label Jun 19, 2025
@CarmenPopoviciu CarmenPopoviciu merged commit ffa742f into main Jun 19, 2025
32 of 33 checks passed
@CarmenPopoviciu CarmenPopoviciu deleted the dario/respect-remote-bindings-flag branch June 19, 2025 11:03
@github-project-automation github-project-automation bot moved this from Approved to Done in workers-sdk Jun 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
e2e Run wrangler + vite-plugin e2e tests on a PR every-os Run tests (unit/e2e/c3-e2e) on every OS, rather than just macOS skip-v3-pr Skip validation of presence of a v3 backport PR
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants