[v3] WC-2965 Prevent selecting in-progress deployments when tailing #9685
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 2b3bdaa The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
WillTaylorDev
force-pushed
the
v3-backport-9684
branch
from
794d593 to
7089b6d
Compare
12 tasks
WalshyDev
reviewed
Jun 20, 2025
packages/wrangler/src/__tests__/pages/pages-deployment-tail.test.ts
Outdated
Show resolved
Hide resolved
packages/wrangler/src/__tests__/pages/pages-deployment-tail.test.ts
Outdated
Show resolved
Hide resolved
WillTaylorDev
force-pushed
the
v3-backport-9684
branch
3 times, most recently
from
b907c15 to
af4eab7
Compare
12 tasks
|
@WillTaylorDev as discussed, please include @mlafeldt as co-author :) |
WillTaylorDev
force-pushed
the
v3-backport-9684
branch
from
af4eab7 to
ecb3598
Compare
|
@WillTaylorDev this PR looks to be superseded by #9684? if so, can we close this one? |
i think this is the v3 backport - i'll update the title to reflect |
emily-shen
changed the title
emily-shen
approved these changes
Jun 26, 2025
lrapoport-cf
added
the
v3-backport
If not provided with a deployment to tail, Wrangler will try to pull the list of deployments and select the most recently created one. However, we do not check whether this deployment has finished. This is causing intermittent errors for users. Co-authored-by: Mathias Lafeldt <[email protected]>
petebacondarwin
force-pushed
the
v3-backport-9684
branch
from
ecb3598 to
2b3bdaa
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If not provided with a deployment to tail, Wrangler will try to pull the list of deployments and select the most recently created one. However, we do not check whether this deployment has finished. This is causing intermittent errors for users.
Backport for #9684