Temporarily skip Openapi C3 e2e tests #9691
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Skipping in yarn due to node version resolution conflicts The Openapi C3 template depends on `chanfana`, which has a dependency on `yargs-parser`. The latest chanfana version (`2.8.1` at the time of this writting) has a dep on `yargs-parser@22` which requires a node version of `20.19.0` or higher. Our CI is currently using node version `20.11.1`. We currently can't bump the CI node version as other tests will fail, therefore skipping for now until we can properly fix
|
CarmenPopoviciu
added
no-changeset-required
skip-v3-pr
petebacondarwin
approved these changes
Jun 20, 2025
create-cloudflare
@cloudflare/kv-asset-handler
miniflare
@cloudflare/pages-shared
@cloudflare/unenv-preset
@cloudflare/vite-plugin
@cloudflare/vitest-pool-workers
@cloudflare/workers-editor-shared
wrangler
commit: |
petebacondarwin
approved these changes
Jun 20, 2025
Comment on lines
-181
to
-192
| { | ||
| template: "openapi", | ||
| variants: [], | ||
| verifyDeploy: { | ||
| route: "/", | ||
| expectedText: "SwaggerUI", | ||
| }, | ||
| verifyPreview: { | ||
| route: "/", | ||
| expectedText: "SwaggerUI", | ||
| }, | ||
| }, |
There was a problem hiding this comment.
Can you either comment out and leave a TODO; or create an issue to add this back in.
There was a problem hiding this comment.
I'm going to create a revert PR immediately after this gets merged
There was a problem hiding this comment.
I will link it here once I have it
There was a problem hiding this comment.
revert PR is here: #9696
CarmenPopoviciu
added a commit
that referenced
this pull request
Jun 20, 2025
This reverts commit 32cb120.
jseba
added a commit
to jseba/workers-sdk
that referenced
this pull request
Jun 20, 2025
…seba/containers_scope_debug * 'main' of ssh://github.com/cloudflare/workers-sdk: Version Packages (cloudflare#9697) add remote bindings support to `getPlatformProxy` (cloudflare#9688) feat(containers): add support for handling images that link to the CF registry (cloudflare#9596) CC-5418: Set instance_type in wrangler (cloudflare#9633) remove warnings during config validations on `experimental_remote` fields (cloudflare#9678) add debug logs for workerd (cloudflare#9640) `wrangler containers apply` uses `observability` configuration (cloudflare#9558) Version Packages (cloudflare#9658) Temporarily skip Openapi C3 e2e tests (cloudflare#9691) Skip authed fixture on forks (cloudflare#9681)
jseba
added a commit
to jseba/workers-sdk
that referenced
this pull request
Jun 21, 2025
…seba/containers_scope * 'main' of ssh://github.com/cloudflare/workers-sdk: Add CLAUDE.md for Claude Code guidance (cloudflare#9563) Version Packages (cloudflare#9697) add remote bindings support to `getPlatformProxy` (cloudflare#9688) feat(containers): add support for handling images that link to the CF registry (cloudflare#9596) CC-5418: Set instance_type in wrangler (cloudflare#9633) remove warnings during config validations on `experimental_remote` fields (cloudflare#9678) add debug logs for workerd (cloudflare#9640) `wrangler containers apply` uses `observability` configuration (cloudflare#9558) Version Packages (cloudflare#9658) Temporarily skip Openapi C3 e2e tests (cloudflare#9691) Skip authed fixture on forks (cloudflare#9681)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Skipping in yarn due to node version resolution conflicts
The Openapi C3 template depends on
chanfana, which has a dependency onyargs-parser. The latest chanfana version (2.8.1at the time of this writting) has a dep onyargs-parser@22which requires a node version of20.19.0or higher. Our CI is currently using node version20.11.1. We currently can't bump the CI node version as other tests will fail, therefore skipping for now until we can properly fixFixes n/a