-
Notifications
You must be signed in to change notification settings - Fork 925
CC-5521: Revert to "dev" when instance type is absent #9717
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CC-5521: Revert to "dev" when instance type is absent #9717
Conversation
When the instance_type field is absent in the wrangler config and no other vcpu, memory, or disk configuration is set, automatically populate the instance_type field with "dev". This way, deleting instance_type from wrangler.jsonc reverts the deployment back to dev.
🦋 Changeset detectedLatest commit: 0dabe35 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
create-cloudflare
@cloudflare/kv-asset-handler
miniflare
@cloudflare/pages-shared
@cloudflare/unenv-preset
@cloudflare/vite-plugin
@cloudflare/vitest-pool-workers
@cloudflare/workers-editor-shared
wrangler
commit: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Can we please get approval from the cloudchamber folks as well 🙏 ?
Congratulations @nikitassharma, the maintainer of this repository has issued you a holobyte! Here it is: https://holopin.io/holobyte/cmcbs6q651025507i5ekyqx9hu This badge can only be claimed by you, so make sure that your GitHub account is linked to your Holopin account. You can manage those preferences here: https://holopin.io/account. |
e2es ran via #9721 |
When the instance_type field is absent in the wrangler config and no other vcpu, memory, or disk configuration is set, automatically populate the instance_type field with "dev".
This way, deleting instance_type from wrangler.jsonc reverts the deployment back to dev.
Fixes CC-5521