Skip to content

Add tests for denying access to .dev.vars in subdirectories #9725

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 1, 2025

Conversation

jamesopstad
Copy link
Contributor

Fixes #000.


  • Tests
    • TODO (before merge)
    • Tests included
    • Tests not necessary because:
  • Wrangler / Vite E2E Tests CI Job required? (Use "e2e" label or ask maintainer to run separately)
    • I don't know
    • Required
    • Not required because: N/A
  • Public documentation
    • TODO (before merge)
    • Cloudflare docs PR(s):
    • Documentation not necessary because: N/A
  • Wrangler V3 Backport
    • TODO (before merge)
    • Wrangler PR:
    • Not necessary because: N/A

Copy link

changeset-bot bot commented Jun 24, 2025

⚠️ No Changeset found

Latest commit: b8a2b39

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

pkg-pr-new bot commented Jun 24, 2025

create-cloudflare

npm i https://pkg.pr.new/create-cloudflare@9725

@cloudflare/kv-asset-handler

npm i https://pkg.pr.new/@cloudflare/kv-asset-handler@9725

miniflare

npm i https://pkg.pr.new/miniflare@9725

@cloudflare/pages-shared

npm i https://pkg.pr.new/@cloudflare/pages-shared@9725

@cloudflare/unenv-preset

npm i https://pkg.pr.new/@cloudflare/unenv-preset@9725

@cloudflare/vite-plugin

npm i https://pkg.pr.new/@cloudflare/vite-plugin@9725

@cloudflare/vitest-pool-workers

npm i https://pkg.pr.new/@cloudflare/vitest-pool-workers@9725

@cloudflare/workers-editor-shared

npm i https://pkg.pr.new/@cloudflare/workers-editor-shared@9725

wrangler

npm i https://pkg.pr.new/wrangler@9725

commit: b8a2b39

@jamesopstad jamesopstad force-pushed the james/test-dev-vars-deny branch from 551e31a to d3f6236 Compare June 24, 2025 14:49
@github-project-automation github-project-automation bot moved this from Untriaged to Approved in workers-sdk Jun 24, 2025
@jamesopstad jamesopstad added the vite-plugin Relating to the `@cloudflare/vite-plugin` package label Jun 30, 2025
@jamesopstad jamesopstad added this pull request to the merge queue Jul 1, 2025
Merged via the queue into main with commit fb84eaa Jul 1, 2025
32 of 37 checks passed
@jamesopstad jamesopstad deleted the james/test-dev-vars-deny branch July 1, 2025 14:15
@github-project-automation github-project-automation bot moved this from Approved to Done in workers-sdk Jul 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-changeset-required vite-plugin Relating to the `@cloudflare/vite-plugin` package
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants