Skip to content

containers: Throw a better error when there is no containers scope in the API token #9731

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 24, 2025

Conversation

gabivlj
Copy link
Contributor

@gabivlj gabivlj commented Jun 24, 2025

Fixes CC-5532

Show a more descriptive error when scopes are not present in the API token.


  • Tests
    • TODO (before merge)
    • Tests included
    • Tests not necessary because:
  • Wrangler / Vite E2E Tests CI Job required? (Use "e2e" label or ask maintainer to run separately)
    • I don't know
    • Required
    • Not required because:
  • Public documentation
    • TODO (before merge)
    • Cloudflare docs PR(s):
    • Documentation not necessary because: fix
  • Wrangler V3 Backport
    • TODO (before merge)
    • Wrangler PR:
    • Not necessary because: containers is not in v3

Copy link

changeset-bot bot commented Jun 24, 2025

🦋 Changeset detected

Latest commit: d390699

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
wrangler Patch
@cloudflare/vitest-pool-workers Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

pkg-pr-new bot commented Jun 24, 2025

create-cloudflare

npm i https://pkg.pr.new/create-cloudflare@9731

@cloudflare/kv-asset-handler

npm i https://pkg.pr.new/@cloudflare/kv-asset-handler@9731

miniflare

npm i https://pkg.pr.new/miniflare@9731

@cloudflare/pages-shared

npm i https://pkg.pr.new/@cloudflare/pages-shared@9731

@cloudflare/unenv-preset

npm i https://pkg.pr.new/@cloudflare/unenv-preset@9731

@cloudflare/vite-plugin

npm i https://pkg.pr.new/@cloudflare/vite-plugin@9731

@cloudflare/vitest-pool-workers

npm i https://pkg.pr.new/@cloudflare/vitest-pool-workers@9731

@cloudflare/workers-editor-shared

npm i https://pkg.pr.new/@cloudflare/workers-editor-shared@9731

wrangler

npm i https://pkg.pr.new/wrangler@9731

commit: d390699

@gabivlj gabivlj marked this pull request as ready for review June 24, 2025 19:40
@gabivlj gabivlj requested review from a team as code owners June 24, 2025 19:40
@gabivlj gabivlj added the e2e Run wrangler + vite-plugin e2e tests on a PR label Jun 24, 2025
Copy link
Contributor

Failed to automatically backport this PR's changes to Wrangler v3. Please manually create a PR targeting the v3-maintenance branch with your changes. Thank you for helping us keep Wrangler v3 supported!

Depending on your changes, running git rebase --onto v3-maintenance main gv/scopes might be a good starting point.

Notes:

  • your PR branch should be named v3-backport-9731
  • add the skip-v3-pr label to the current PR to stop this workflow from failing

@gabivlj gabivlj added the skip-v3-pr Skip validation of presence of a v3 backport PR label Jun 24, 2025
Copy link
Member

@dario-piotrowicz dario-piotrowicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🙂

@github-project-automation github-project-automation bot moved this from Untriaged to Approved in workers-sdk Jun 24, 2025
@gabivlj gabivlj added this pull request to the merge queue Jun 24, 2025
Merged via the queue into main with commit 75b75f3 Jun 24, 2025
29 of 40 checks passed
@gabivlj gabivlj deleted the gv/scopes branch June 24, 2025 20:14
@github-project-automation github-project-automation bot moved this from Approved to Done in workers-sdk Jun 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
e2e Run wrangler + vite-plugin e2e tests on a PR skip-v3-pr Skip validation of presence of a v3 backport PR
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants