-
Notifications
You must be signed in to change notification settings - Fork 925
CFSQL-1261: remove the need for d1 to patch wrangler for testing #9748
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🦋 Changeset detectedLatest commit: 4a19ef3 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
create-cloudflare
@cloudflare/kv-asset-handler
miniflare
@cloudflare/pages-shared
@cloudflare/unenv-preset
@cloudflare/vite-plugin
@cloudflare/vitest-pool-workers
@cloudflare/workers-editor-shared
wrangler
commit: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you add a changeset? Even though it's an internal-only option
Failed to automatically backport this PR's changes to Wrangler v3. Please manually create a PR targeting the Depending on your changes, running Notes:
|
061c6e0
to
422b919
Compare
422b919
to
4a19ef3
Compare
relates to CFSQL-1261
Describe your change...
On the D1 team, we are internally carrying a patch to add some fake location hints to create d1 databases in our internal staging environments.
When pairing with @penalosa , he thought that it would be better to make this into an environment variable so we don't have to carry a patch. This will make it easier to keep up with wrangler releases automatically in future.