Skip to content

CFSQL-1261: remove the need for d1 to patch wrangler for testing #9748

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 3, 2025

Conversation

alsuren
Copy link
Contributor

@alsuren alsuren commented Jun 25, 2025

relates to CFSQL-1261

Describe your change...

On the D1 team, we are internally carrying a patch to add some fake location hints to create d1 databases in our internal staging environments.

When pairing with @penalosa , he thought that it would be better to make this into an environment variable so we don't have to carry a patch. This will make it easier to keep up with wrangler releases automatically in future.


  • Tests
    • TODO (before merge)
    • Tests included
    • Tests not necessary because: only used internally for d1 tests
  • Wrangler / Vite E2E Tests CI Job required? (Use "e2e" label or ask maintainer to run separately)
    • I don't know
    • Required
    • Not required because: only used internally for d1 tests
  • Public documentation
    • TODO (before merge)
    • Cloudflare docs PR(s):
    • Documentation not necessary because: only used internally for d1 tests
  • Wrangler V3 Backport
    • TODO (before merge)
    • Wrangler PR:
    • Not necessary because: only used internally for d1 tests

@alsuren alsuren requested review from a team as code owners June 25, 2025 12:41
Copy link

changeset-bot bot commented Jun 25, 2025

🦋 Changeset detected

Latest commit: 4a19ef3

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
wrangler Patch
@cloudflare/vitest-pool-workers Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

pkg-pr-new bot commented Jun 25, 2025

create-cloudflare

npm i https://pkg.pr.new/create-cloudflare@9748

@cloudflare/kv-asset-handler

npm i https://pkg.pr.new/@cloudflare/kv-asset-handler@9748

miniflare

npm i https://pkg.pr.new/miniflare@9748

@cloudflare/pages-shared

npm i https://pkg.pr.new/@cloudflare/pages-shared@9748

@cloudflare/unenv-preset

npm i https://pkg.pr.new/@cloudflare/unenv-preset@9748

@cloudflare/vite-plugin

npm i https://pkg.pr.new/@cloudflare/vite-plugin@9748

@cloudflare/vitest-pool-workers

npm i https://pkg.pr.new/@cloudflare/vitest-pool-workers@9748

@cloudflare/workers-editor-shared

npm i https://pkg.pr.new/@cloudflare/workers-editor-shared@9748

wrangler

npm i https://pkg.pr.new/wrangler@9748

commit: 4a19ef3

@github-project-automation github-project-automation bot moved this from Untriaged to Approved in workers-sdk Jun 25, 2025
Copy link
Contributor

@penalosa penalosa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add a changeset? Even though it's an internal-only option

@github-project-automation github-project-automation bot moved this from Approved to In Review in workers-sdk Jun 25, 2025
Copy link
Contributor

Failed to automatically backport this PR's changes to Wrangler v3. Please manually create a PR targeting the v3-maintenance branch with your changes. Thank you for helping us keep Wrangler v3 supported!

Depending on your changes, running git rebase --onto v3-maintenance main dlaban/CFSQL-1261-remove-need-for-d1-patches might be a good starting point.

Notes:

  • your PR branch should be named v3-backport-9748
  • add the skip-v3-pr label to the current PR to stop this workflow from failing

@alsuren alsuren added the skip-v3-pr Skip validation of presence of a v3 backport PR label Jun 26, 2025
@alsuren alsuren requested a review from penalosa June 27, 2025 09:34
@github-project-automation github-project-automation bot moved this from In Review to Approved in workers-sdk Jun 30, 2025
@penalosa penalosa force-pushed the dlaban/CFSQL-1261-remove-need-for-d1-patches branch from 061c6e0 to 422b919 Compare June 30, 2025 13:50
@alsuren alsuren force-pushed the dlaban/CFSQL-1261-remove-need-for-d1-patches branch from 422b919 to 4a19ef3 Compare July 3, 2025 10:15
@alsuren alsuren added this pull request to the merge queue Jul 3, 2025
Merged via the queue into main with commit 7e3aa1b Jul 3, 2025
35 of 36 checks passed
@alsuren alsuren deleted the dlaban/CFSQL-1261-remove-need-for-d1-patches branch July 3, 2025 12:48
@github-project-automation github-project-automation bot moved this from Approved to Done in workers-sdk Jul 3, 2025
@workers-devprod workers-devprod mentioned this pull request Jul 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip-v3-pr Skip validation of presence of a v3 backport PR
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants