Build containers without account ID

[hasip-timurtas]

This allows us to build containers in dry run mode. When we push the container to the managed registry, we re-tag it to include the account ID. We only ever push when not in dry run mode though, so when pushing we can safely grab the account information.

Related: #9813, #9811

---

• Tests
  • Tests included
  • Tests not necessary because:
• Public documentation
  • Cloudflare docs PR(s):
  • Documentation not necessary because: bug fix
• Wrangler V3 Backport
  • Wrangler PR:
  • Not necessary because: do not backport containers changes

[changeset-bot]

🦋 Changeset detected

Latest commit: ec6bd2e

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages

Name	Type
wrangler	Patch
@cloudflare/vite-plugin	Patch
@cloudflare/vitest-pool-workers	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[emily-shen]

hey thanks so much for the contribution! are you able to add a test and a changeset? you can find more details in our contributing guide: https://github.com/cloudflare/workers-sdk/blob/main/CONTRIBUTING.md#testing but feel free to ask here as well if you get stuck :)

[hasip-timurtas]

@emily-shen I tested manually, it fixes the issue I had 😅
But yep sure, I will add the changeset and unit test as well. Will push soon, thanks for checking.

[hasip-timurtas]

@emily-shen check it again please

[pkg-pr-new]

create-cloudflare

npm i https://pkg.pr.new/create-cloudflare@9765

@cloudflare/kv-asset-handler

npm i https://pkg.pr.new/@cloudflare/kv-asset-handler@9765

miniflare

npm i https://pkg.pr.new/miniflare@9765

@cloudflare/pages-shared

npm i https://pkg.pr.new/@cloudflare/pages-shared@9765

@cloudflare/unenv-preset

npm i https://pkg.pr.new/@cloudflare/unenv-preset@9765

@cloudflare/vite-plugin

npm i https://pkg.pr.new/@cloudflare/vite-plugin@9765

@cloudflare/vitest-pool-workers

npm i https://pkg.pr.new/@cloudflare/vitest-pool-workers@9765

@cloudflare/workers-editor-shared

npm i https://pkg.pr.new/@cloudflare/workers-editor-shared@9765

wrangler

npm i https://pkg.pr.new/wrangler@9765

commit: ec6bd2e

[hasip-timurtas]

CI Failures - Unrelated to Container Fix

The CI failures appear to be flaky test issues unrelated to the container dry-run changes:

Main Fix Status ✅

The core wrangler test suite passed (325/325 tests), including the new test for the container URL parsing fix.

Failed Tests (Infrastructure Issues)

1. vitest-pool-workers - Network error (ECONNRESET)
2. create-cloudflare e2e - Authentication timeout (tries to open browser in CI)
3. dev-registry - Tail event timing issue (failed 3x, likely race condition)

These test different components (test infrastructure, CLI scaffolding, dev session communication) than the container deployment code I modified.

Success rate: 91/95 test suites passed (95.8%)

Could someone re-run the failed jobs? The container dry-run URL parsing fix is working correctly.

[petebacondarwin]

The C3 tests will always fail right now due to this PR being on a fork. The other failures are probably just flakes.

[petebacondarwin]

I'll rebase and rerun once we fix the C3 tests.

[gpanders]

I'd like to suggest an alternative approach.

Right now, we don't fill out the OpenAPI configuration when we use dry run mode. This is actually a nice property because it gives us a kind of soft-guarantee that we won't interact with the API in dry run mode.

As you found, this breaks because buildAndMaybePush loads the user account limits using the API, even in dry run mode. However, it only does this to validate disk limits on the account before pushing.

I suggest changing buildAndMaybePush to only load the account and call ensureDiskLimits when dry run mode is disabled. That lets us maintain the property that we do not fill out the OpenAPI configuration in dry run mode and should only require changing buildAndMaybePush, which will be a much smaller and tighter scoped change.

[gpanders]

I've rebased on main and implemented the changes I suggested.

Thanks @hasip-timurtas for the issue report and initial work on this. Apologies for hijacking your PR, but in this case it was much faster to do it myself rather than go back and forth via GitHub. Thanks very much for your contribution :)

[holopin-bot]

Congratulations @hasip-timurtas, the maintainer of this repository has issued you a holobyte! Here it is: https://holopin.io/holobyte/cmcw0m11w198807leui0ol2cf

This badge can only be claimed by you, so make sure that your GitHub account is linked to your Holopin account. You can manage those preferences here: https://holopin.io/account.
Or if you're new to Holopin, you can simply sign up with GitHub, which will do the trick!