Skip to content

Fix the v3 backport message to use v3-backport-PR #9777

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jun 27, 2025
Merged

Fix the v3 backport message to use v3-backport-PR #9777

merged 3 commits into from
Jun 27, 2025

Conversation

vicb
Copy link
Contributor

@vicb vicb commented Jun 27, 2025 •
edited
Loading

Ref the correct branch + clarify that the PR should be manually created.(that was a bug fixed in the follow up commit - we tried to create a PR from the wrong branch using v3-maintenance-... instead of v3-backport-...)

  • Tests
    • Tests included
    • Tests not necessary because: CI
  • Public documentation
    • Cloudflare docs PR(s):
    • Documentation not necessary because: not needed
  • Wrangler V3 Backport
    • Wrangler PR:
    • Not necessary because: CI

@vicb vicb requested a review from a team as a code owner June 27, 2025 08:12
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Jun 27, 2025 •
edited
Loading

⚠️ No Changeset found

Latest commit: bb47ccb

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-project-automation github-project-automation bot moved this to Untriaged in workers-sdk Jun 27, 2025
@pkg-pr-new pkg.pr.new
Copy link

pkg-pr-new bot commented Jun 27, 2025 •
edited
Loading

create-cloudflare

npm i https://pkg.pr.new/create-cloudflare@9777

@cloudflare/kv-asset-handler

npm i https://pkg.pr.new/@cloudflare/kv-asset-handler@9777

miniflare

npm i https://pkg.pr.new/miniflare@9777

@cloudflare/pages-shared

npm i https://pkg.pr.new/@cloudflare/pages-shared@9777

@cloudflare/unenv-preset

npm i https://pkg.pr.new/@cloudflare/unenv-preset@9777

@cloudflare/vite-plugin

npm i https://pkg.pr.new/@cloudflare/vite-plugin@9777

@cloudflare/vitest-pool-workers

npm i https://pkg.pr.new/@cloudflare/vitest-pool-workers@9777

@cloudflare/workers-editor-shared

npm i https://pkg.pr.new/@cloudflare/workers-editor-shared@9777

wrangler

npm i https://pkg.pr.new/wrangler@9777

commit: bb47ccb

CarmenPopoviciu
CarmenPopoviciu reviewed Jun 27, 2025
View reviewed changes
.github/workflows/open-v3-maintenance-prs.yml Outdated
@@ -63,4 +63,4 @@ jobs:
with:
header: v3-backport
message: |
These changes have been automatically backported to Wrangler v3 :tada: You can view the automatically updated PR at https://github.com/cloudflare/workers-sdk/compare/v3-maintenance...v3-maintenance-${{ github.event.number }}. Please check that PR for correctness, and make sure it's merged after this one. Thank you for helping us keep Wrangler v3 supported!
These changes have been automatically backported to Wrangler v3 :tada: You can view the v3 changes at https://github.com/cloudflare/workers-sdk/compare/v3-maintenance...v3-backport-${{ github.event.number }}. Please check that diff for correctness, create a PR if it looks good, and make sure it's merged after this one. Thank you for helping us keep Wrangler v3 supported!
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

create a PR if it looks good

isn't the PR automatically created?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was not for #9776 - but let's wait for other to chime in the discussion

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking at tools/deployments/open-v3-pr.ts it it supposed to be....

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But I guess --head v3-maintenance-${process.env.PR_NUMBER} is buggy there, I'll update that too

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh...yeah, that failed with https://github.com/cloudflare/workers-sdk/actions/runs/15921226878/job/44908246659?pr=9775#step:5:22

@github-project-automation github-project-automation bot moved this from Untriaged to Approved in workers-sdk Jun 27, 2025
@vicb vicb force-pushed the vicb/v3-backport branch from 792412c to 959ad77 Compare June 27, 2025 08:30
@vicb vicb force-pushed the vicb/v3-backport branch from 959ad77 to bb47ccb Compare June 27, 2025 08:33
@vicb vicb added this pull request to the merge queue Jun 27, 2025
Merged via the queue into main with commit 3ed8dcd Jun 27, 2025
26 checks passed
@vicb vicb deleted the vicb/v3-backport branch June 27, 2025 08:45
@github-project-automation github-project-automation bot moved this from Approved to Done in workers-sdk Jun 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CarmenPopoviciu CarmenPopoviciu CarmenPopoviciu approved these changes

Assignees
No one assigned
Labels
no-changeset-required
Projects
workers-sdk
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vicb @CarmenPopoviciu