Fix not starting inspector proxy for miniflare workers created by setOptions

[Mkassabov]

Fixes miniflare workers created by setOptions not being able to be accessed via the inspector proxy

When InspectorProxyController.updateConnection() is called pass in an updated set of workers to inspect. To facilitate creating this set #workerNamesToProxy() has been created on Miniflare since it needs occur multiple times, not just during instantiation.

---

• Tests
  • Tests included
  • Tests not necessary because:
• Public documentation
  • Cloudflare docs PR(s):
  • Documentation not necessary because: miniflare bug fix
• Wrangler V3 Backport
  • Wrangler PR:
  • Not necessary because: miniflare internal change

[changeset-bot]

🦋 Changeset detected

Latest commit: fec8da7

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 5 packages

Name	Type
miniflare	Patch
@cloudflare/pages-shared	Patch
@cloudflare/vite-plugin	Patch
@cloudflare/vitest-pool-workers	Patch
wrangler	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[pkg-pr-new]

create-cloudflare

npm i https://pkg.pr.new/create-cloudflare@9784

@cloudflare/kv-asset-handler

npm i https://pkg.pr.new/@cloudflare/kv-asset-handler@9784

miniflare

npm i https://pkg.pr.new/miniflare@9784

@cloudflare/pages-shared

npm i https://pkg.pr.new/@cloudflare/pages-shared@9784

@cloudflare/unenv-preset

npm i https://pkg.pr.new/@cloudflare/unenv-preset@9784

@cloudflare/vite-plugin

npm i https://pkg.pr.new/@cloudflare/vite-plugin@9784

@cloudflare/vitest-pool-workers

npm i https://pkg.pr.new/@cloudflare/vitest-pool-workers@9784

@cloudflare/workers-editor-shared

npm i https://pkg.pr.new/@cloudflare/workers-editor-shared@9784

wrangler

npm i https://pkg.pr.new/wrangler@9784

commit: fec8da7

[Mkassabov]

Seeing tests failing here, but not really sure what to do about them since they seem like credential issues. Is this just a matter of the PR not being from a cloudflare employee?

FWIW this is a purely miniflare change so it shouldn't effect C3.

Please let me know if there is anything I can do to help get this across the line! <3

[petebacondarwin]

Seeing tests failing here, but not really sure what to do about them since they seem like credential issues. Is this just a matter of the PR not being from a cloudflare employee?

FWIW this is a purely miniflare change so it shouldn't effect C3.

Please let me know if there is anything I can do to help get this across the line! <3

Yeah the failing tests are because the PR is on a fork. It is not your fault.
I'll fix and merge. Thanks!

[Mkassabov]

If this is still having issues because it's a fork I don't mind if somebody from CF just rewrites the changes so they are not in a fork.

More interested in seeing this issue fixed than getting credit for it or anything.

Sorry if I made a mess with this <3

[petebacondarwin]

Don't worry - we are just having some issues with a flakey merge queue. Will land it today.

[holopin-bot]

Congratulations @Mkassabov, the maintainer of this repository has issued you a holobyte! Here it is: https://holopin.io/holobyte/cmcs26y5t659907jucmpwuije

This badge can only be claimed by you, so make sure that your GitHub account is linked to your Holopin account. You can manage those preferences here: https://holopin.io/account.
Or if you're new to Holopin, you can simply sign up with GitHub, which will do the trick!