Also handle next apps hosted on a subpath #9785
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: deb55b5 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
create-cloudflare
@cloudflare/kv-asset-handler
miniflare
@cloudflare/pages-shared
@cloudflare/unenv-preset
@cloudflare/vite-plugin
@cloudflare/vitest-pool-workers
@cloudflare/workers-editor-shared
wrangler
commit: |
vicb
reviewed
Jun 28, 2025
| @@ -272,6 +272,31 @@ describe("unit tests", async () => { | |||
| expect(await response.text()).toBe("Blocked"); | |||
| }); | |||
|
|
|||
| it("blocks /_next/image requests with remote URLs when not fetched as image for next apps host not at the root", async () => { | |||
There was a problem hiding this comment.
Maybe:
Suggested change
| it("blocks /_next/image requests with remote URLs when not fetched as image for next apps host not at the root", async () => { | |
| it("blocks /base/path/_next/image requests with remote URLs when not fetched as image", async () => { |
I think using it.each to parametrize the test by path would be nice here to remove duplication.
vicb
approved these changes
Jun 28, 2025
Next apps can be hosted on a subpath, i.e. not at the root, so we need to be a little more permissive with the path we check on.
matthewdavidrodgers
force-pushed
the
next-base-paths
branch
from
14c4a2a to
deb55b5
Compare
vicb
approved these changes
Jul 2, 2025
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
petebacondarwin
approved these changes
Jul 2, 2025
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Next apps can be hosted on a subpath, i.e. not at the root, so we need to be a little more permissive with the path we check on.
Fixes #[insert GH or internal issue link(s)].
Describe your change...