Skip to content

Better messaging for account owned tokens #9799

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jul 2, 2025

Conversation

penalosa
Copy link
Contributor

@penalosa penalosa commented Jun 30, 2025

Fixes https://jira.cfdata.org/browse/BUGS-1468

This improves the wrangler whoami output for Account owned tokens to no longer show errors about being unable to load the user's email.

Before:
Screenshot 2025-06-30 at 17 51 51
After:
Screenshot 2025-06-30 at 17 54 45


  • Tests
    • Tests included
    • Tests not necessary because:
  • Public documentation
    • Cloudflare docs PR(s):
    • Documentation not necessary because: minor messaging improvements
  • Wrangler V3 Backport

Copy link

changeset-bot bot commented Jun 30, 2025

🦋 Changeset detected

Latest commit: a96b69e

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
wrangler Patch
@cloudflare/vitest-pool-workers Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

pkg-pr-new bot commented Jun 30, 2025

create-cloudflare

npm i https://pkg.pr.new/create-cloudflare@9799

@cloudflare/kv-asset-handler

npm i https://pkg.pr.new/@cloudflare/kv-asset-handler@9799

miniflare

npm i https://pkg.pr.new/miniflare@9799

@cloudflare/pages-shared

npm i https://pkg.pr.new/@cloudflare/pages-shared@9799

@cloudflare/unenv-preset

npm i https://pkg.pr.new/@cloudflare/unenv-preset@9799

@cloudflare/vite-plugin

npm i https://pkg.pr.new/@cloudflare/vite-plugin@9799

@cloudflare/vitest-pool-workers

npm i https://pkg.pr.new/@cloudflare/vitest-pool-workers@9799

@cloudflare/workers-editor-shared

npm i https://pkg.pr.new/@cloudflare/workers-editor-shared@9799

wrangler

npm i https://pkg.pr.new/wrangler@9799

commit: a96b69e

@workers-devprod workers-devprod added the c3-e2e Run c3 e2e tests on a PR label Jul 1, 2025
@penalosa penalosa force-pushed the penalosa/account-owned-messaging branch from 9609ac9 to c8ff0f5 Compare July 1, 2025 10:35
@penalosa penalosa marked this pull request as ready for review July 1, 2025 10:35
@penalosa penalosa requested a review from a team as a code owner July 1, 2025 10:35
@github-project-automation github-project-automation bot moved this from Untriaged to Approved in workers-sdk Jul 1, 2025
Copy link
Contributor

github-actions bot commented Jul 1, 2025

Failed to automatically backport this PR's changes to Wrangler v3. Please manually create a PR targeting the v3-maintenance branch with your changes. Thank you for helping us keep Wrangler v3 supported!

Depending on your changes, running git rebase --onto v3-maintenance main penalosa/account-owned-messaging might be a good starting point.

Notes:

  • your PR branch should be named v3-backport-9799
  • add the skip-v3-pr label to the current PR to stop this workflow from failing

@penalosa penalosa added the skip-v3-pr Skip validation of presence of a v3 backport PR label Jul 1, 2025
@penalosa penalosa force-pushed the penalosa/account-owned-messaging branch from 6dd426f to d02f221 Compare July 1, 2025 11:25
@penalosa penalosa added this pull request to the merge queue Jul 1, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jul 1, 2025
@penalosa penalosa added this pull request to the merge queue Jul 1, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jul 1, 2025
@penalosa penalosa enabled auto-merge July 1, 2025 15:01
@workers-devprod workers-devprod added the e2e Run wrangler + vite-plugin e2e tests on a PR label Jul 1, 2025
@penalosa penalosa added this pull request to the merge queue Jul 1, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jul 1, 2025
@penalosa penalosa added this pull request to the merge queue Jul 2, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jul 2, 2025
@penalosa penalosa added this pull request to the merge queue Jul 2, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jul 2, 2025
@penalosa penalosa enabled auto-merge July 2, 2025 09:49
@penalosa penalosa added this pull request to the merge queue Jul 2, 2025
Merged via the queue into main with commit d11288a Jul 2, 2025
30 checks passed
@penalosa penalosa deleted the penalosa/account-owned-messaging branch July 2, 2025 10:50
@github-project-automation github-project-automation bot moved this from Approved to Done in workers-sdk Jul 2, 2025
@workers-devprod workers-devprod mentioned this pull request Jul 2, 2025
@petebacondarwin petebacondarwin mentioned this pull request Jul 2, 2025
6 tasks
petebacondarwin added a commit that referenced this pull request Jul 7, 2025
* Better messaging for account owned tokens

* Create thin-grapes-rescue.md

* fix tests

* Update packages/wrangler/src/user/whoami.ts

Co-authored-by: Pete Bacon Darwin <[email protected]>

* further fixups

---------

Co-authored-by: Pete Bacon Darwin <[email protected]>
Co-authored-by: Peter Bacon Darwin <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c3-e2e Run c3 e2e tests on a PR e2e Run wrangler + vite-plugin e2e tests on a PR skip-v3-pr Skip validation of presence of a v3 backport PR
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants