Skip to content

R2-3182: Remove wrangler Banner from R2 GetObject in Pipe Mode #9800

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

helloimalastair
Copy link
Contributor

@helloimalastair helloimalastair commented Jun 30, 2025

Fixes R2-3182.

When using the --pipe flag for wrangler r2 object get, outputting the wrangler header breaks the file that is created, since it isn't actually a part of the object content.


  • Tests
    • Tests included
    • Tests not necessary because:
  • Wrangler / Vite E2E Tests CI Job required? (Use "e2e" label or ask maintainer to run separately)
    • I don't know
    • Required
    • Not required because:
  • Public documentation
    • Cloudflare docs PR(s):
    • Documentation not necessary because: No changes to what the user needs to do to use the command.
  • Wrangler V3 Backport
    • Wrangler PR:
    • [] Not necessary because:

@helloimalastair helloimalastair requested a review from a team as a code owner June 30, 2025 18:15
Copy link

changeset-bot bot commented Jun 30, 2025

🦋 Changeset detected

Latest commit: c74e797

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
wrangler Patch
@cloudflare/vitest-pool-workers Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

pkg-pr-new bot commented Jun 30, 2025

create-cloudflare

npm i https://pkg.pr.new/create-cloudflare@9800

@cloudflare/kv-asset-handler

npm i https://pkg.pr.new/@cloudflare/kv-asset-handler@9800

miniflare

npm i https://pkg.pr.new/miniflare@9800

@cloudflare/pages-shared

npm i https://pkg.pr.new/@cloudflare/pages-shared@9800

@cloudflare/unenv-preset

npm i https://pkg.pr.new/@cloudflare/unenv-preset@9800

@cloudflare/vite-plugin

npm i https://pkg.pr.new/@cloudflare/vite-plugin@9800

@cloudflare/vitest-pool-workers

npm i https://pkg.pr.new/@cloudflare/vitest-pool-workers@9800

@cloudflare/workers-editor-shared

npm i https://pkg.pr.new/@cloudflare/workers-editor-shared@9800

wrangler

npm i https://pkg.pr.new/wrangler@9800

commit: c74e797

@WalshyDev WalshyDev added the skip-v3-pr Skip validation of presence of a v3 backport PR label Jun 30, 2025
@penalosa penalosa removed the skip-v3-pr Skip validation of presence of a v3 backport PR label Jun 30, 2025
@penalosa
Copy link
Contributor

penalosa commented Jul 1, 2025

@helloimalastair this will need a backport

Copy link
Contributor

@emily-shen emily-shen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this behaviour has in fact regressed several times across various commands 🥲 - would you be able to add a test?

we mock out the banner in tests so you'll have to add vi.unmock("../wrangler-banner");

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Untriaged
Development

Successfully merging this pull request may close these issues.

4 participants