-
Notifications
You must be signed in to change notification settings - Fork 925
R2-3182: Remove wrangler
Banner from R2 GetObject in Pipe Mode
#9800
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
🦋 Changeset detectedLatest commit: c74e797 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
create-cloudflare
@cloudflare/kv-asset-handler
miniflare
@cloudflare/pages-shared
@cloudflare/unenv-preset
@cloudflare/vite-plugin
@cloudflare/vitest-pool-workers
@cloudflare/workers-editor-shared
wrangler
commit: |
7ae0759
to
ae602cd
Compare
@helloimalastair this will need a backport |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this behaviour has in fact regressed several times across various commands 🥲 - would you be able to add a test?
we mock out the banner in tests so you'll have to add vi.unmock("../wrangler-banner");
efd9e77
to
c74e797
Compare
Fixes R2-3182.
When using the
--pipe
flag forwrangler r2 object get
, outputting thewrangler
header breaks the file that is created, since it isn't actually a part of the object content.