Use the right token when checking out external forks

[penalosa]

No description provided.

[changeset-bot]

⚠️ No Changeset found

Latest commit: 0c238c4

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

[pkg-pr-new]

create-cloudflare

npm i https://pkg.pr.new/create-cloudflare@9829

@cloudflare/kv-asset-handler

npm i https://pkg.pr.new/@cloudflare/kv-asset-handler@9829

miniflare

npm i https://pkg.pr.new/miniflare@9829

@cloudflare/pages-shared

npm i https://pkg.pr.new/@cloudflare/pages-shared@9829

@cloudflare/unenv-preset

npm i https://pkg.pr.new/@cloudflare/unenv-preset@9829

@cloudflare/vite-plugin

npm i https://pkg.pr.new/@cloudflare/vite-plugin@9829

@cloudflare/vitest-pool-workers

npm i https://pkg.pr.new/@cloudflare/vitest-pool-workers@9829

@cloudflare/workers-editor-shared

npm i https://pkg.pr.new/@cloudflare/workers-editor-shared@9829

wrangler

npm i https://pkg.pr.new/wrangler@9829

commit: 0c238c4

[dario-piotrowicz]

Can you explain why the change? 🤔

The workflow already has contents: read under permissions, is that not enough to checkout the repo? 🫤

[penalosa]

Can you explain why the change? 🤔

The workflow already has contents: read under permissions, is that not enough to checkout the repo? 🫤

It's enough to checkout the repo, yeah, but it's not enough to push to the repo. Checking out with the token means that the later push has permission

[petebacondarwin]

@dario-piotrowicz - see 28ecf85#diff-900be2a000a3c8e9022554fe17d14efc73ea31b1e7ee16052bcc166b9411ed42R19

[dario-piotrowicz]

Can you explain why the change? 🤔
The workflow already has contents: read under permissions, is that not enough to checkout the repo? 🫤

It's enough to checkout the repo, yeah, but it's not enough to push to the repo. Checking out with the token means that the later push has permission

Sorry I totally missed your reply 😓

What I was saying is that you were adding the token for the checkout step... that's why I am not getting why it is needed 😕