thomasgauvin: add rename command to kv wrangler #9835
Conversation
|
create-cloudflare
@cloudflare/kv-asset-handler
miniflare
@cloudflare/pages-shared
@cloudflare/unenv-preset
@cloudflare/vite-plugin
@cloudflare/vitest-pool-workers
@cloudflare/workers-editor-shared
wrangler
commit: |
packages/wrangler/src/kv/index.ts
Outdated
| throw new UserError("Unable to determine namespace ID"); | ||
| } | ||
|
|
||
| if (!args.newName) { |
There was a problem hiding this comment.
i don't think this is necessary, yargs should already have errored
packages/wrangler/src/kv/index.ts
Outdated
| namespaceId = namespace.id; | ||
| } | ||
|
|
||
| if (!namespaceId) { |
There was a problem hiding this comment.
i dont think this check is necessary? or at the least, it shouldn't be a user error - either it'll have been set by args or already errored out above.
if its a types issue, you should use assert to narrow the type.
packages/wrangler/src/kv/index.ts
Outdated
| metrics.sendMetricsEvent("rename kv namespace", { | ||
| sendMetrics: config.send_metrics, | ||
| }); |
There was a problem hiding this comment.
this is no longer necessary, all commands have metrics automatically added for start/complete/error.
addresses #7765