fix experimental remoteBindings flag not being properly propagated in getPlatformProxy

[dario-piotrowicz]

The changes here address the fact that experimental remoteBindings flag that user can set in their getPlatformProxy call is currently not being properly propagated, causing most of the bindings not to actually be treated as remote ones

---

• Tests
  • Tests included
  • Tests not necessary because:
• Public documentation
  • Cloudflare docs PR(s):
  • Documentation not necessary because: bugfix
• Wrangler V3 Backport
  • Wrangler PR:
  • Not necessary because: bugfix to a non-v3 feature

[changeset-bot]

🦋 Changeset detected

Latest commit: 2a0c7dd

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages

Name	Type
wrangler	Patch
@cloudflare/vitest-pool-workers	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[pkg-pr-new]

create-cloudflare

npm i https://pkg.pr.new/create-cloudflare@9840

@cloudflare/kv-asset-handler

npm i https://pkg.pr.new/@cloudflare/kv-asset-handler@9840

miniflare

npm i https://pkg.pr.new/miniflare@9840

@cloudflare/pages-shared

npm i https://pkg.pr.new/@cloudflare/pages-shared@9840

@cloudflare/unenv-preset

npm i https://pkg.pr.new/@cloudflare/unenv-preset@9840

@cloudflare/vite-plugin

npm i https://pkg.pr.new/@cloudflare/vite-plugin@9840

@cloudflare/vitest-pool-workers

npm i https://pkg.pr.new/@cloudflare/vitest-pool-workers@9840

@cloudflare/workers-editor-shared

npm i https://pkg.pr.new/@cloudflare/workers-editor-shared@9840

wrangler

npm i https://pkg.pr.new/wrangler@9840

commit: 2a0c7dd

[vicb]

causing most of the bindings

is there a list of bingings impacted instead of "most" ?

[vicb]

Looking at the tests it looks like the only diff is KV?

[shafkathullah]

causing most of the bindings

is there a list of bingings impacted instead of "most" ?

Everything that support "experimental_remote": true as I've experienced. Looking forward to this PR merge to resolve the issue I am having now.

[dario-piotrowicz]

causing most of the bindings

is there a list of bingings impacted instead of "most" ?

"most" basically means all the bindings besides service ones, those worked before my changes (because of this erroneous line: https://github.com/cloudflare/workers-sdk/pull/9840/files#diff-564e7822c281c216ba6926ff5334b704657d6c80483b42f46c8de51ef1f1d5ccL209)

I'll clarify this in the changeset 👍

[dario-piotrowicz]

causing most of the bindings

is there a list of bingings impacted instead of "most" ?

Everything that support "experimental_remote": true as I've experienced. Looking forward to this PR merge to resolve the issue I am having now.

I'm sorry to have inconvenienced you 😓

If you hit these sort of issues please feel always free to open issues in the repository so that we can help out 🙂

[shafkathullah]

causing most of the bindings

is there a list of bingings impacted instead of "most" ?

Everything that support "experimental_remote": true as I've experienced. Looking forward to this PR merge to resolve the issue I am having now.

I'm sorry to have inconvenienced you 😓

If you hit these sort of issues please feel always free to open issues in the repository so that we can help out 🙂

No worries, I initially thought the issue was with @astro/cloudflare package, but someone from astro community guide me to here.

[dario-piotrowicz]

@vicb I've updated the changeset hopefully it is more clear now

Regarding the tests indeed I've only added a test for KV as I think that it'd be very impractical to test all the possible bindings here, one should hopefully be enough to give us confidence that the flag is being correctly propagated, let me know if you disagree

[vicb]

Thanks!

[shafkathullah]

@dario-piotrowicz

I see 2 more bugs, think it's related to this getPlatformProxy

• preview_database_id is not being picked on dev runs ie, when using say @astro/cloudflare adapter and running astro dev
• environment field is not properly propagated, ie passing that field has no effect, but if wrong value is passed ie, not available in wrangler.jsonc an error is thrown.

also these works fine when running wrangler from CLI ie, wrangler dev so the issue is not with wrangler CLI.

[dario-piotrowicz]

Hi @shafkathullah, thanks for letting me know

Could you open 2 bug issues for these?
(If you could also share a minimal reproduction (which only uses getPlatformProxy) that would be great)